Handle NestedInstallerType in WinGet manifest

[duckblaster]

Some packages have installers wrapped in a zip file, for a specific example see DisplayLink.GraphicsDriver.

[svrooij]

When packaging "Adobe.Acrobat.Pro" via WinTuner, it currently generates the script based installation (install.ps1 -> calling winget directly...), so I had a look in the package manifest of the latest version and noticed, that the InstallerType is "zip" and there is a "NestedInstallerType" with "exe".
Can WinTuner please support this scenario (Check for nested installer type, extract zip and put the package together as for other supported installer types)?
Especially for such big installers, having everything together in Intune packages and being capable for delivery optimization would be of great advantage.
And finally: Thank you! For all the effort you put into this really handful toolset!

#244 (comment) by @DanielZ0815

[svrooij]

I'm my opinion Nested Installers should not exist in winget. Why would you want to zip the actual installer? It does not do anything.

But I agree that it would be better to also support these, just no idea how. If someone can create a decent spec of how this feature should work, I might give copilot a go.

[DanielZ0815]

I have no idea why Adobe decided to use a zip with a NestedInstaller instead of a self-extracting exe installer. When I find some time I try to analyze your code and identify the areas that would need to be changed to support this...

[svrooij]

I meant a function description like:

1. If it's a 'NestedInstaller', it should handle it
2. Extract the zip
3. Package the resulting file(s)
4. Set setup file and arguments
5. Arguments are in this place for nested installers

[DanielZ0815]

Ah ok, you mean some kind of pseudo-code 😄
Yes, basically special handling is required when InstallerType = zip and there is a NestedInstallerType in the manifest.
In that case

• The zip should be extracted
• Install commands logic and technology should be determined based on the NestedInstallerType information
• The setup file should be taken from NestedInstallerFiles.RelativeFilePath of the manifest
• The installation argument should be taken from InstallerSwitches.Silent of the manifest

Everything based on the Adobe Acrobat pro example:
https://github.com/microsoft/winget-pkgs/blob/master/manifests/a/Adobe/Acrobat/Pro/25.001.20756/Adobe.Acrobat.Pro.installer.yaml

More information about the manifest options described here:
https://github.com/microsoft/winget-pkgs/blob/master/doc/manifest/schema/1.10.0/installer.md

I found also packages in the manifests that have InstallerType = zip and NestedInstallerType = portable. (e.g. https://github.com/microsoft/winget-pkgs/blob/master/manifests/0/0xJacky/nginx-ui/2.1.17/0xJacky.nginx-ui.installer.yaml)
Don't know if you want to support these as well. If yes, it looks like it's just extract the zip (where to?) and they are ready to use.

[svrooij]

Don't know if you want to support these as well.

Currently there is no support for the "portable" installer type.

This is a great start to get me going

[fly0815666]

Hi @svrooij , any update on this? Are you planning to implement support for nested (non-portable) installers in (near) future? 😅