Skip to content

Commit c448666

Browse files
authored
Make --early-readiness the default (#28)
Co-authored-by: Moritz Clasmeier <mclasmeier@redhat.com>
1 parent 8c3d9d2 commit c448666

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

‎cmd/main.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ Red Hat Advanced Cluster Security (ACS) on any Kubernetes/OpenShift cluster.`,
4343

4444
func init() {
4545
rootCmd.PersistentFlags().BoolVarP(&verbose, "verbose", "v", false, "Enable verbose output (show CRs and Helm values)")
46-
rootCmd.PersistentFlags().BoolVar(&earlyReadiness, "early-readiness", false, "Only wait for essential workloads (central/sensor), not all workloads")
46+
rootCmd.PersistentFlags().BoolVar(&earlyReadiness, "early-readiness", true, "Only wait for essential workloads (central/sensor) to be ready")
4747
rootCmd.AddCommand(newDeployCmd())
4848
rootCmd.AddCommand(newTeardownCmd())
4949
rootCmd.AddCommand(newVersionCmd())

‎tests/e2e/e2e_test.go‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,10 @@ const (
2323
)
2424

2525
var (
26-
commonDeployArgs = []string{"--port-forwarding", "--exposure=none", "--resources=small", "--early-readiness"}
27-
commonDeployArgsNoPortForward = []string{"--exposure=loadbalancer", "--resources=small", "--early-readiness"}
28-
roxieBinary string
26+
commonDeployArgs = []string{"--port-forwarding", "--exposure=none", "--resources=small"}
27+
commonDeployArgsNoPortForward = []string{"--exposure=loadbalancer", "--resources=small"}
28+
29+
roxieBinary string
2930
)
3031

3132
func TestMain(m *testing.M) {
@@ -293,7 +294,7 @@ func TestDeployBothComponentsTogether(t *testing.T) {
293294

294295
t.Log("=== Deploying both components ===")
295296
// We also test --pause-reconciliation flag here.
296-
args := append([]string{roxieBinary, "deploy", "both", "--early-readiness", "--pause-reconciliation", "--envrc", envrcPath}, commonDeployArgsNoPortForward...)
297+
args := append([]string{roxieBinary, "deploy", "both", "--pause-reconciliation", "--envrc", envrcPath}, commonDeployArgsNoPortForward...)
297298
runCommand(t, deployTimeout*2, nil, args...)
298299

299300
t.Log("Verifying namespace: acs-central")

0 commit comments

Comments
 (0)