Question about including 3rd-party dependencies (e.g., stripe/stripe-php) in a custom Stripe driver

[edrisranjbar]

Hi, I'm planning to implement a Stripe driver for this package (since it's listed as "will be added soon" and help is requested via PRs).
To properly integrate Stripe, I would need to use their official PHP SDK: stripe/stripe-php.
Before I start working on the driver, I want to ask:
Are contributors allowed to add 3rd-party package dependencies (via composer.json) when implementing a new driver?
If yes, should the dependency be required globally for the whole package, or would you prefer a more decoupled approach (e.g., using interfaces and letting the end-user install the SDK themselves)?

I understand that adding a dependency increases the package's footprint, but for a driver like Stripe, the official SDK is the most reliable way to handle API calls, webhooks, and checkout sessions.

Thank you for clarifying the policy. I'm happy to follow any guidelines you set.

[mahdimsr]

I'm not the repository owner, but as a follower and a big fan of this package, my preference is that the dependency should not be required for the entire project. Instead, whenever a user wants to use a feature that depends on a specific package, they can install it themselves.

The important point is that the documentation should clearly specify which gateways require additional dependencies to be installed.

Thanks for following this up. We should wait for the repository owner's final decision.

[edrisranjbar]

@mahdimsr Thanks for the advice. Yeah I do think this approach is better since most of the users are Iranian and mostly do not use this driver (and even if they did) it's not the best choise to add a dependency to the library.
maybe we need to add mention in the docs that this particular driver needs that certain dependency and here's the way to import it.
anyway; I'm certenly eager to see whats the repo owner and other's opinion.

[khanzadimahdi]

I see 2 aproaches:

1- to setup/configure the driver, the additional steps should be mentioned as part of the docs. this includes the dependencies that should be installed.
2- write the driver with minimal steps to take! so the dependencies should be installed as part of the package.

I am more into approach 2, so the package contains all dependencies it needs. what do you think? @mahdimsr @edrisranjbar

btw, each approach has pros and cons! the trade-offs can be dicussed further.