-
Notifications
You must be signed in to change notification settings - Fork 1k
Misses some files but catching others in big workspace #6887
Copy link
Copy link
Open
Labels
C-bugCategory: this is a bug; use also I-* labels for specific bug kinds, e.g. I-non-idempotency or I-ICECategory: this is a bug; use also I-* labels for specific bug kinds, e.g. I-non-idempotency or I-ICES-needs-reproStatus: this issue has no reproduction and needs a reproduction to make progressStatus: this issue has no reproduction and needs a reproduction to make progressneeds-triageThis issue or PR needs triaging to determine its status. Remove label once sufficiently triaged.This issue or PR needs triaging to determine its status. Remove label once sufficiently triaged.
Metadata
Metadata
Assignees
Labels
C-bugCategory: this is a bug; use also I-* labels for specific bug kinds, e.g. I-non-idempotency or I-ICECategory: this is a bug; use also I-* labels for specific bug kinds, e.g. I-non-idempotency or I-ICES-needs-reproStatus: this issue has no reproduction and needs a reproduction to make progressStatus: this issue has no reproduction and needs a reproduction to make progressneeds-triageThis issue or PR needs triaging to determine its status. Remove label once sufficiently triaged.This issue or PR needs triaging to determine its status. Remove label once sufficiently triaged.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Summary
Running
'cargo fmt --check -- --config unstable_features=true --config binop_separator=Back --config imports_granularity=Module --config group_imports=StdExternalCrate'
on servo github (revision f3bdb24d2a43853721ea757fee704ef250df9c56) shows everything is formatted ok
but the same command with --all (cargo fmt --check -- --config unstable_features=true --config binop_separator=Back --config imports_granularity=Module --config group_imports=StdExternalCrate) shows that the files 'components/script/dom/stream/readablestream.rs' and 'components/script/dom/webxr/xrsessions.rs' have their imports not correctly sorted.
Other files in the crate (components/script) get correctly formatted.
Meta
I am not sure if this is expected behavior or a bug but it is weird that it only seems to affect these few files.