feat: establish APM facade contract#269
Open
rlaope wants to merge 1 commit into
Open
Conversation
Create a public APM facade foundation before exposing distributed APM workflows through product surfaces. Constraint: public APM APIs must stay separated from unauthenticated aggregator internals and must preserve tenant/project/environment/service context. Rejected: direct browser or public facade coupling to raw aggregator routes | it would bypass the hardened APM boundary. Confidence: high Scope-risk: broad Directive: future APM endpoints must authorize scope before data lookup and preserve structured service identity in backend links. Tested: node --check argus-frontend/src/main/resources/public/js/apm.js; git diff --cached --check; ./gradlew :argus-apm:test --tests io.argus.apm.ApmSecurityAndGuardrailsTest; ./gradlew :argus-server:test --tests io.argus.server.metrics.DashboardStaticAssetsSmokeTest; Playwright smoke for live scope links, structured service identity, local href sanitization, malformed payload fail-closed, and preview mode; clean-worktree ./gradlew test. Not-tested: none. Signed-off-by: rlaope <piyrw9754@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
argus-apmas the public APM facade contract module with scoped models, DTOs, backend link routing, JVM-finding correlation, demo topology, guardrails, authorization, and self-metrics.Distributed Environment Check
request.serviceinto the authorized scope before allowing a link response.namespace/namewhen facade payloads provide{ namespace, name }, reducing collision risk across namespaces./fleet,/api/pods, or/profileroutes.Review Fixes Included
Verification
node --check argus-frontend/src/main/resources/public/js/apm.jsgit diff --cached --check./gradlew :argus-apm:test --tests io.argus.apm.ApmSecurityAndGuardrailsTest./gradlew :argus-server:test --tests io.argus.server.metrics.DashboardStaticAssetsSmokeTest./gradlew testLocal Note
* 2.java; they are intentionally not part of this PR. A clean worktree test passed without them.