Merge pull request #71 from niteeshkanna-sh/claude/stoic-rubin-fnglq7

The Inquiries badge counts what nobody has opened

Author: niteeshkanna-sh

admin/admin.css

@@ -965,6 +965,16 @@ label.finance-toggle {
   transition: box-shadow 0.15s ease;
 }
 .enquiry-card:hover { box-shadow: var(--shadow); }
+/* Not yet opened by anyone. A gold edge and a heavier name, so the ones that
+   still need a first look are findable in the list and not only countable in
+   the sidebar. Deliberately quiet: this marks "new to you", not "urgent". */
+.enquiry-card.is-unread { border-left: 3px solid var(--accent); }
+.enquiry-card.is-unread .enquiry-name { font-weight: 800; }
+.enquiry-card.is-unread .num::after {
+  content: 'Unread'; margin-left: 8px; padding: 1px 7px; border-radius: 999px;
+  background: #FFF3DC; color: var(--accent-deep); font-size: 0.68rem;
+  font-weight: 700; letter-spacing: 0.02em; vertical-align: 1px;
+}
 .enquiry-card .row { display: flex; flex-direction: column; gap: 4px; min-width: 0; }
 .enquiry-card .num { font-weight: 800; color: var(--accent-deep); font-size: 0.9rem; }
 .enquiry-card .enquiry-name { font-weight: 700; color: var(--ink); font-size: 1rem; }

admin/admin.js

@@ -496,23 +496,41 @@ document.getElementById('enquirySearch')?.addEventListener('input', (e) => {
   }, 300);
 });
 
+/**
+ * The number beside Inquiries in the sidebar: how many nobody has opened.
+ *
+ * Unread, not unresolved. An enquiry stays Contacted for days while somebody
+ * waits on a callback, and a badge that sits on 1 the whole time is a badge
+ * nobody reads -- the morning it says 3 looks like every other morning. The
+ * server counts it, because the list on screen is filtered and the badge is
+ * about the whole table.
+ */
+function setInquiryBadge(unread) {
+  const badge = document.getElementById('inquiryCount');
+  if (!badge) return;
+  // Emptied rather than zeroed: the stylesheet hides an empty badge, and a
+  // grey "0" beside Inquiries is a thing to read every morning that never
+  // means anything.
+  badge.textContent = Number(unread) || '';
+}
+
 async function renderInquiries() {
   const wrap = document.getElementById('inquiriesWrap');
-  const countBadge = document.getElementById('inquiryCount');
   if (!wrap) return;
 
-  let enquiries;
+  let answer;
   try {
-    enquiries = (await api.enquiries.list(enquiryStatusFilter, enquirySearch)).enquiries;
+    answer = await api.enquiries.list(enquiryStatusFilter, enquirySearch);
   } catch (err) {
     wrap.innerHTML = '<div class="empty-state">Could not load enquiries.</div>';
     showError(err);
     return;
   }
-
-  // The badge counts what still needs attention, not everything ever received.
-  const outstanding = enquiries.filter((e) => ['New', 'Contacted', 'Pending'].includes(e.status)).length;
-  if (countBadge) countBadge.textContent = outstanding || '';
+  const enquiries = answer.enquiries;
+  setInquiryBadge(answer.unread);
+  // Only mark cards when the database knows what has been read. Otherwise
+  // every viewed_at is null and the whole list would claim to be unread.
+  const tracksRead = answer.tracks_read !== false;
 
   if (!enquiries.length) {
     wrap.innerHTML = enquirySearch || enquiryStatusFilter
@@ -522,7 +540,7 @@ async function renderInquiries() {
   }
 
   wrap.innerHTML = enquiries.map((e) => `
-    <div class="enquiry-card" data-id="${e.id}">
+    <div class="enquiry-card${tracksRead && !e.viewed_at ? ' is-unread' : ''}" data-id="${e.id}">
       <div class="row">
         <span class="num">${e.enquiry_number}</span>
         <span class="enquiry-name">${escapeHTML(e.name)}</span>
@@ -576,7 +594,12 @@ async function renderEnquiry(id) {
   const body = document.getElementById('enquiryModalBody');
   let e;
   try {
-    e = (await api.enquiries.get(id)).enquiry;
+    const answer = await api.enquiries.get(id);
+    e = answer.enquiry;
+    // Opening it is what marks it read, so the badge is right the moment the
+    // modal appears rather than after the next refresh of the list behind it.
+    setInquiryBadge(answer.unread);
+    document.querySelector(`.enquiry-card[data-id="${id}"]`)?.classList.remove('is-unread');
   } catch (err) {
     body.innerHTML = '<p class="detail-empty">Could not load this enquiry.</p>';
     showError(err);

admin/api/enquiries.php

@@ -2,6 +2,7 @@
 declare(strict_types=1);
 
 require_once __DIR__ . '/../src/booking.php';
+require_once __DIR__ . '/../src/enquiry.php';
 
 /**
  * Enquiry management.
@@ -50,13 +51,28 @@
             $params
         );
 
-        json_out(['enquiries' => array_map('present_enquiry', $rows)]);
+        json_out([
+            'enquiries' => array_map('present_enquiry', $rows),
+            // Sent with the list so the badge never needs a request of its own,
+            // and counted over the whole table rather than the rows returned --
+            // the list is filtered and paged, the badge is not.
+            'unread'      => enquiry_unread(),
+            // Whether this database tracks reading at all. Without it every
+            // row's viewed_at is null, which is indistinguishable from never
+            // opened -- and a panel one migration behind would mark the whole
+            // list unread. Nothing is marked until the column exists.
+            'tracks_read' => enquiry_read_ready(),
+        ]);
     }
 
     // ----------------------------------------------------------------- get --
     case 'get': {
-        api_guard('enquiry.view');
-        $row = fetch_one(
+        // Not a write guard: this is a GET, and passing true would demand a
+        // POST. Marking the enquiry read below is a side effect of reading it,
+        // the way opening a message marks it read, and the worst a forged
+        // request could do is clear a badge for somebody already signed in.
+        $user = api_guard('enquiry.view');
+        $row  = fetch_one(
             'SELECT e.*, v.name AS vehicle_name, b.booking_number
                FROM enquiries e
                LEFT JOIN vehicles v ON v.id = e.vehicle_id
@@ -67,7 +83,14 @@
         if ($row === null) {
             json_error('That enquiry no longer exists.', 404);
         }
-        json_out(['enquiry' => present_enquiry($row, true)]);
+        // Opening it is what counts as reading it -- the badge clears itself
+        // rather than waiting for somebody to change the status.
+        enquiry_mark_seen((int) $row['id'], (int) $user['id']);
+
+        json_out([
+            'enquiry' => present_enquiry($row, true),
+            'unread'  => enquiry_unread(),
+        ]);
     }
 
     // --------------------------------------------------------------- status --
@@ -315,6 +338,7 @@ function present_enquiry(array $row, bool $detailed = false): array
         'source'          => $row['source'],
         'booking_number'  => $row['booking_number'],
         'created_at'      => $row['created_at'],
+        'viewed_at'       => $row['viewed_at'] ?? null,
     ];
 
     if ($detailed) {

admin/sql/013_enquiry_read.sql

@@ -0,0 +1,22 @@
+-- An enquiry that has been looked at, and who looked.
+--
+-- The sidebar badge used to count everything not yet resolved, which meant it
+-- sat on "1" from the moment an enquiry arrived until somebody closed it out
+-- days later. A number that is always on is a number nobody reads, and the
+-- one morning it says 3 looks the same as every other morning.
+--
+-- Read and resolved are different questions. Status says where the enquiry
+-- got to; this says whether anyone has seen it. The badge asks the second.
+ALTER TABLE enquiries
+  ADD COLUMN viewed_at DATETIME     NULL AFTER handled_at,
+  ADD COLUMN viewed_by INT UNSIGNED NULL AFTER viewed_at;
+
+ALTER TABLE enquiries
+  ADD KEY ix_enquiries_unread (viewed_at),
+  ADD CONSTRAINT fk_enquiries_viewer FOREIGN KEY (viewed_by) REFERENCES users (id);
+
+-- Everything already dealt with counts as seen. Without this the badge would
+-- light up with the whole history the first time the panel loads after the
+-- update, which is exactly the noise this is meant to remove.
+UPDATE enquiries SET viewed_at = COALESCE(handled_at, created_at)
+ WHERE status <> 'New' AND viewed_at IS NULL;

admin/src/enquiry.php

@@ -0,0 +1,53 @@
+<?php
+declare(strict_types=1);
+
+require_once __DIR__ . '/db.php';
+
+/**
+ * Which enquiries have been looked at.
+ *
+ * Read and resolved are different questions. Status says where an enquiry got
+ * to -- contacted, accepted, converted. This says whether anybody has opened
+ * it yet, which is what the sidebar badge is actually asking.
+ */
+
+/**
+ * Whether this database knows what has been read.
+ *
+ * Guarded like every other new column, so a panel that has not run the
+ * migration yet keeps working -- it simply never shows an unread count.
+ */
+function enquiry_read_ready(): bool
+{
+    return table_has_column('enquiries', 'viewed_at');
+}
+
+/**
+ * How many enquiries nobody has opened.
+ *
+ * This is what the sidebar badge counts. Not "how many are unresolved": an
+ * enquiry stays Contacted for days while somebody waits for a callback, and a
+ * badge that sits on 1 the whole time is one nobody looks at, so the morning
+ * it says 3 reads the same as every other morning.
+ */
+function enquiry_unread(): int
+{
+    if (!enquiry_read_ready()) {
+        return 0;
+    }
+    return (int) (fetch_one(
+        'SELECT COUNT(*) AS n FROM enquiries WHERE viewed_at IS NULL'
+    )['n'] ?? 0);
+}
+
+/** Stamps an enquiry as seen, the first time it is opened and never again. */
+function enquiry_mark_seen(int $id, int $userId): void
+{
+    if (!enquiry_read_ready()) {
+        return;
+    }
+    // The condition matters: opening an enquiry a second time must not move
+    // the timestamp, or "when was this first picked up" stops being answerable.
+    query('UPDATE enquiries SET viewed_at = NOW(), viewed_by = ?
+            WHERE id = ? AND viewed_at IS NULL', [$userId, $id]);
+}

build.json

@@ -1,7 +1,7 @@
 {
-  "publishedAt": "2026-09-22T10:11:10.934Z",
-  "commit": "81fb4734",
-  "commitAt": "2026-09-22T09:50:03+00:00",
+  "publishedAt": "2026-09-22T10:27:20.417Z",
+  "commit": "6d3ff940",
+  "commitAt": "2026-09-22T10:11:50+00:00",
   "assets": [
     "About-DF8GNQ_N.js",
     "Bikes-igQ3kzmM.js",