(route-metadata (routes)) fails validation

[neverfox]

If you call routes without arguments, you cannot run route-metadata on the result, despite nothing filing validation up to that point:

(route-metadata (routes))

Unhandled clojure.lang.ExceptionInfo
   Input to breadth-route-metadata* does not match schema: [nil nil (named (not
   (puppetlabs.kitchensink.core/zipper? nil)) loc)]

[cprice404]

Interesting, thanks, I'll look into this.

Out of curiosity, do you have a use case where you actually end up calling routes without any arguments?

[neverfox]

Essentially, I ran into this when I was attempting to establish a starting "empty" state for a collection of routes that would be added to over time with successive calls to routes, i.e. a sort-of reduction. While I can probably find a way around it, I just thought you might want to be aware that there is a case where a valid RoutePair (["" []]) doesn't work with route-metadata.

[cprice404]

Makes sense, thanks for the heads up.

[neverfox]

Sure thing. I'm not sure if it's better to make route-metadata gracefully handle that or to make this an upstream problem with the Schema, i.e. that that shouldn't be valid.

[neverfox]

BTW, do you have any recommendations with regard to "composing" bidi routes built up from different sources into a single tree? It's touted as a feature but the fact that they're in vector form (as opposed to, say, maps) makes it rather unwieldy to merge different route trees cleanly and easily.

[cprice404]

@neverfox re: route-metadata or upstream; when we get a sec we'll probably try doing it via route-metadata first.

Re: composing routes - TBH it's something that should be doable and seems like one of the advantages of bidi in general, but we haven't actually done much of it. It might require some additional utility functions being added to the library. Worst case scenario it seems like it would be fairly easy to write a transformation function (zipper, probably) that converted a map route into a vector route, and then it'd be easier to compose them.

Without that it'd probably require having knowledge of your various route data structures and composing them by hand.