Repository navigation
Commit 3683486
fix(x): only a missing account may count against a source's health (#157)
`fetchXSource` treated every failure except a rate limit as evidence about
the account. So a provider outage, a dead session, or no provider being
configured at all incremented `error_count` — and `markCrawlFailure`
retires a feed at ten consecutive failures.
An X source polls on a five-minute floor. Ten strikes is fifty minutes.
That makes the ordinary order of operations destructive: setting
`X_ENABLED=true` before a provider is reachable is how you find out
whether it is reachable, and it would have marked every X source dead
within the hour, logging "these accounts are broken" rather than "nothing
is configured to collect with".
The comment above the line already claimed the correct behaviour — that a
deleted, suspended or protected account is the one failure genuinely about
the source. The code did the opposite. Now only `XNoSuchSource` reaches
`markCrawlFailure`; everything else returns `throttled`, which moves
`next_fetch_at` and leaves `status`, `error_count`, `last_error` and
`last_success_at` untouched.
Retry intervals by cause, because they are three different guesses about
when the situation changes: a rate limit uses the interval the server
named; an outage waits twenty minutes; "no provider configured" waits an
hour, since nothing changes until somebody deploys something.
Five tests, four of which fail against the merged code.
Claude-Session: https://claude.ai/code/session_01Q6QEgpuS4MLamogXtr2ZX6
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent 4ab9ca9 commit 3683486
2 files changed
Lines changed: 122 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
118 | 132 | | |
119 | | - | |
120 | | - | |
121 | | - | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
122 | 140 | | |
123 | 141 | | |
124 | 142 | | |
| |||
149 | 167 | | |
150 | 168 | | |
151 | 169 | | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
152 | 194 | | |
153 | 195 | | |
154 | 196 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
445 | 445 | | |
446 | 446 | | |
447 | 447 | | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
0 commit comments