Skip to content

CONTRIBUTING.md

Latest commit

聽

History

History
142 lines (89 loc) 路 5.4 KB

CONTRIBUTING.md

File metadata and controls

142 lines (89 loc) 路 5.4 KB
Raw

Contributing

Contributions are always welcome, no matter how large or small!

We want this community to be friendly and respectful to each other. Please follow it in all your interactions with the project. Before contributing, please read the code of conduct.

Development workflow

This project is a monorepo managed using Yarn workspaces. It contains the following packages:

  • The library package in the root directory.
  • An example app in the example/ directory.

To get started with the project, make sure you have the correct version of Node.js installed. See the .nvmrc file for the version used in this project.

Run yarn in the root directory to install the required dependencies for each package:

yarn

Since the project relies on Yarn workspaces, you cannot use npm for development without manually migrating.

You need to run React Native Codegen to generate the native scaffolding for the C++ Turbo Module. The example app will not build without these generated files.

Run Codegen in following cases:

  • When you make changes to src/NativeColumnar.ts.
  • When running the project for the first time (since the generated files are not committed to the repository).

To invoke Codegen, use the following command:

yarn bob build --target codegen

The example app demonstrates usage of the library. You need to run it to test any changes you make.

It is configured to use the local version of the library, so any changes you make to the library's source code will be reflected in the example app. Changes to the library's JavaScript code will be reflected in the example app without a rebuild, but native code changes will require a rebuild of the example app.

If you want to use Android Studio or Xcode to edit the native code, you can open the example/android or example/ios directories respectively in those editors. To edit the Objective-C or Swift files, open example/ios/ColumnarExample.xcworkspace in Xcode and find the source files at Pods > Development Pods > react-native-columnar.

To edit the Java or Kotlin files, open example/android in Android studio and find the source files at react-native-columnar under Android.

You can use various commands from the root directory to work with the project.

To start the packager:

yarn example start

To run the example app on Android:

yarn example android

To run the example app on iOS:

yarn example ios

To confirm that the app is running with the new architecture, you can check the Metro logs for a message like this:

Running "ColumnarExample" with {"fabric":true,"initialProps":{"concurrentRoot":true},"rootTag":1}

Note the "fabric":true and "concurrentRoot":true properties.

Make sure your code passes TypeScript:

yarn typecheck

To check for linting errors, run the following:

yarn lint

To fix formatting errors, run the following:

yarn lint --fix

On-device tests (react-native-harness)

The C++ writer and the JS reader are tested together inside the example app with React Native Harness. Tests live in example/__tests__/*.harness.ts; the native side they call is installTestBindings in example/ios/JSITest.mm.

  1. Build and install the debug example app on the simulator you want to use (yarn example ios --udid <UDID>).
  2. Run the tests (Harness starts its own Metro):
yarn example test:harness

By default Harness uses the iPhone 17 Pro Max simulator on iOS 26.5 and Metro port 8081. Override them per machine with environment variables, for example to run on a dedicated simulator while another Metro occupies 8081:

HARNESS_IOS_SIMULATOR="Columnar 17 Pro Max" HARNESS_IOS_VERSION=26.5 HARNESS_METRO_PORT=8092 yarn example test:harness

Pass a file name to run a single suite, e.g. yarn example test:harness resize. After changing cpp/ or JSITest.mm, rebuild the app before running the tests; JS-only changes don't need a rebuild.

Publishing to npm

We use release-it to make it easier to publish new versions. It handles common tasks like bumping version based on semver, creating tags and releases etc.

To publish new versions, run the following:

yarn release

Scripts

The package.json file contains various scripts for common tasks:

  • yarn: setup project by installing dependencies.
  • yarn typecheck: type-check files with TypeScript.
    • yarn lint: lint files with ESLint.
      • yarn example start: start the Metro server for the example app.
  • yarn example android: run the example app on Android.
  • yarn example ios: run the example app on iOS.

Sending a pull request

Working on your first pull request? You can learn how from this free series: How to Contribute to an Open Source Project on GitHub.

When you're sending a pull request:

  • Prefer small pull requests focused on one change.
  • Verify that linters and tests are passing.
  • Review the documentation to make sure it looks good.
  • Follow the pull request template when opening a pull request.
  • For pull requests that change the API or implementation, discuss with maintainers first by opening an issue.