fix: #5329 repair unit tests after v1.8.0 merge#5330
Merged
Conversation
Repairs failures introduced by the v1.8.0 merge:
- journal_defaults.json: split the fused author_affiliation_dates /
a11y_public_info entry (duplicate keys silently dropped the setting,
causing Setting.DoesNotExist) and remove a duplicate
subject_production_complete entry.
- clean and material article templates: close unclosed {% if %} blocks
and remove duplicated galley download blocks (also fixes a duplicate
note_to_proofreader_2 id).
- review notify tests: save the active editor so editor_user_required
does not redirect to login; assignment_notification view now passes
the article object (not its pk) to the template so se_can_see_pii works.
- repository: add a SQLite _search override on PreprintSearchManager
using preprintauthor (the base hardcodes Article's frozenauthor).
- contacts_box_person.html: anonymise author name/email with
se_can_see_pii so section editors cannot see PII.
- add DefaultSettingsIntegrityTests to guard journal_defaults.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repairs failures introduced by the v1.8.0 merge: