Two functions in cf_cmd.c and one in cf_utils.c have complexity > 15

[alexandercalder]

cf_cmd.c:

• CF_WriteQueueCmd, complexity 30
• CF_GetSetParamCmd, complexity 22

cf_utils.c

• CF_TxnStatus_To_ConditionCode, 18

Change the code to reduce the complexity or add comments explaining why the complexity value is acceptable in this case.

[jphickey]

Note - with respect to the CF_WriteQueueCmd (and some other code in CF) some of this complexity stems from the fact that there is not a consistent definition for "all" when it comes to the queue selectors.

For example: the type selector (for up/down) reserves the value 0 as "all" where singular selections are [1-2]. In contrast, the queue selector defines "all" as 3 and the singular selections range from [0-2]. As a result of this type of inconsistency, we cannot have common code patterns doing this type of selection logic -- all the conditionals have to be explicit "if" checks specifically for the type of resource being checked.

As part of doing this, I would recommend updating these enums to be consistent in the patterns used. Zero should be reserved as "everything" and singular selections should be nonzero.