NOTE: Heavily edited from original Issue submission (see Edits)
When an file has an OR rule for multiple codeowner groups, the system does not dismiss unneeded reviewer groups when one of the codeowners groups is satisfied.
- File 1 requires team A or B to approve
- A member of team A approves, satisfying the required reviews for File 1
- Team B still requested for review
Expected Behavior:
Since the rule A or B is satisfied by A approval, the requested review for B is no longer necessary, and ought to be dismissed
Actual Behavior:
The system keeps the review request for group B active, even though it's already been satisfied.
NOTE: Heavily edited from original Issue submission (see Edits)
When an file has an
ORrule for multiple codeowner groups, the system does not dismiss unneeded reviewer groups when one of the codeowners groups is satisfied.Expected Behavior:
Since the rule
A or Bis satisfied byAapproval, the requested review forBis no longer necessary, and ought to be dismissedActual Behavior:
The system keeps the review request for group B active, even though it's already been satisfied.