Skip to content

Latest version of Rerun-Action stops CodeOwners step from passing. #195

Description

@wloggains-mmllc

Summary

The README's GitHub Actions Setup workflow keys its concurrency group on the branch, but check runs are published against a commit:

concurrency:
  group: codeowners-${{ github.ref }}
  cancel-in-progress: true
on:
  pull_request:
    types: [opened, reopened, synchronize, ready_for_review, labeled, unlabeled]

ready_for_review, labeled and unlabeled fire without changing the head SHA, so one commit can collect two Run Codeowners Plus runs. GitHub does not dedupe check runs by name. The first run will be cancelled while the second one succeeds. It reads as a codeowners-plus rejection. Important to note is that this can block CI if a user makes the step required. (We do not.)

What made it start failing: shqear93/rerun-checks v3.1.0

Pairing this workflow with rerun-checks to re-evaluate on pull_request_review: submitted is the trigger. Upstream commit 50237c74 changed target selection from one match to all matches:

checkRuns.find(cr => cr.name === name)     // before one target, nothing to collide with
checkRuns.filter(cr => cr.name === name)   // v3.1.0 one target per duplicate

Reproduction

  1. Push a commit.
  2. Set draft as ready to review, then set it back to draft. This will stack multiple runs of CO plus on the commit.
  3. Submit any review. A plain comment review works. Both re-run and one is cancelled.

Suggested change

In the README and in this repo's own .github/workflows/codeowners.yml:

 concurrency:
   group: codeowners-${{ github.ref }}
-  cancel-in-progress: true
+  cancel-in-progress: false

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions