Skip to content

Commit 9ca924d

Browse files
edvilmeCopilot
andcommitted
Fix tests that did not exercise their intended behavior
- managerCapabilities.integration.test.ts: the delegation test queried packages.manage.upgrade (undeclared) instead of packages.manage.install (the key that actually delegates to packages.manage), so it silently passed by coincidence rather than exercising cross-module delegation. The cycle test declared packages.manage -> packages.manage.install but never wired the reverse edge, so no cycle existed to detect. - api/test/consumer.ts: removed a duplicate @ts-expect-error assertion for 'environments.create.named', which is rejected the same way as any other non-catalog string literal and is already covered by the generic arbitraryKey assertion immediately below it. - packageManagerHeadlessConformance.unit.test.ts: fixed two import statements that had been merged onto a single line. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 0334387 commit 9ca924d

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

‎api/test/consumer.ts‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,9 +123,6 @@ if (!support.supported) {
123123
({ 'packages.unknown': async () => ({ supported: true }) } satisfies Capabilities<PackageManagerCapability>);
124124
// @ts-expect-error Operation options are not capability query context.
125125
({ createOptions: { quickCreate: true } } satisfies CapabilityContext);
126-
// @ts-expect-error Named creation is deferred rather than an enabled capability.
127-
resolveEnvironmentManagerCapability(legacyEnvironmentManager, 'environments.create.named');
128-
129126
declare const arbitraryKey: string;
130127
// @ts-expect-error A general string is not a declared environment capability.
131128
resolveEnvironmentManagerCapability(legacyEnvironmentManager, arbitraryKey);

‎src/test/integration/managerCapabilities.integration.test.ts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,14 +160,16 @@ suite('Manager capabilities integration', function () {
160160
'packages.manage.install': (context) =>
161161
resolvePackageManagerCapability(packages, 'packages.manage', context),
162162
};
163-
assert.deepStrictEqual(await api.getPackageManagerCapability(environment, 'packages.manage.upgrade'), denied);
163+
assert.deepStrictEqual(await api.getPackageManagerCapability(environment, 'packages.manage.install'), denied);
164164
});
165165

166166
test('prerequisite cycles are detected across separately loaded API modules', async () => {
167167
packageCapabilities = {
168168
...noPackageCapabilities,
169169
'packages.manage': (context) =>
170170
resolvePackageManagerCapability(packages, 'packages.manage.install', context),
171+
'packages.manage.install': (context) =>
172+
resolvePackageManagerCapability(packages, 'packages.manage', context),
171173
};
172174
await assert.rejects(
173175
() => api.getPackageManagerCapability(environment, 'packages.manage'),

‎src/test/managers/common/packageManagerHeadlessConformance.unit.test.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ import * as windowApis from '../../../common/window.apis';
1616
import * as workspaceFs from '../../../common/workspace.fs.apis';
1717
import * as workspaceApis from '../../../common/workspace.apis';
1818
import { InternalPackageManager } from '../../../managers/common/registeredManagers';
19-
import { PipInstallCommand } from '../../../managers/builtin/commands/install';import { PipListCommand } from '../../../managers/builtin/commands/list';
19+
import { PipInstallCommand } from '../../../managers/builtin/commands/install';
20+
import { PipListCommand } from '../../../managers/builtin/commands/list';
2021
import * as helpers from '../../../managers/builtin/helpers';
2122
import { PipPackageManager } from '../../../managers/builtin/pipPackageManager';
2223
import * as pipUtils from '../../../managers/builtin/pipUtils';

0 commit comments

Comments
 (0)