Skip to content

Commit 67d6dc3

Browse files
karthiknadigCopilot
andcommitted
chore: keep maintainer PRs draft through validation (Fixes #491)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent d13f6f4 commit 67d6dc3

1 file changed

Lines changed: 9 additions & 7 deletions

File tree

‎.github/agents/Maintainer.agent.md‎

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ git commit -m "feat: add Pixi environment detection (Fixes #42)"
212212
git push -u origin feature/issue-N
213213
```
214214

215-
Create a Draft PR via `github/create_pull_request`:
215+
Create a Draft PR via `github/create_pull_request` and keep it draft throughout Copilot review, review fixes, CI, and quality snapshot inspection. Do not mark it ready merely to request review:
216216

217217
- **Title:** Same as commit message (or summarized if multiple commits)
218218
- **Body:** Keep it concise:
@@ -313,15 +313,17 @@ Before merging, inspect the completed workflow results and PR comments, not just
313313

314314
# Merge & Cleanup
315315

316-
Once review is complete and all checks pass:
316+
Once review is complete, all checks pass, and the quality snapshot is acceptable:
317317

318-
1. **Merge the PR:**
318+
1. **Mark the PR ready:** Transition out of draft only now, immediately before merge or enabling auto-merge.
319+
320+
2. **Merge the PR:**
319321

320322
```
321323
github/merge_pull_request
322324
```
323325

324-
2. **Delete the feature branch:**
326+
3. **Delete the feature branch:**
325327

326328
```powershell
327329
git checkout main; git pull
@@ -332,11 +334,11 @@ Once review is complete and all checks pass:
332334

333335
Skip `git push origin --delete <branch>` if GitHub already auto-deleted the remote branch.
334336

335-
3. **Verify the merge postcondition:** Run `gh pr view N --json state,mergedAt,autoMergeRequest` after requesting merge or auto-merge. Do not treat a zero exit code as sufficient; require `state` to be `MERGED` with `mergedAt` populated, or `autoMergeRequest` to be populated when required checks are still pending.
337+
4. **Verify the merge postcondition:** Run `gh pr view N --json state,mergedAt,autoMergeRequest` after requesting merge or auto-merge. Do not treat a zero exit code as sufficient; require `state` to be `MERGED` with `mergedAt` populated, or `autoMergeRequest` to be populated when required checks are still pending.
336338

337-
4. **CI triggers:** Push to main runs the full CI pipeline (builds, tests, artifact uploads).
339+
5. **CI triggers:** Push to main runs the full CI pipeline (builds, tests, artifact uploads).
338340

339-
5. **Continuous maintenance mode:** When the user explicitly asks for autonomous continuation, refresh the open issue/PR queue after cleanup, select the highest-impact ready issue with no overlapping PR, and restart the Development Phase. Do not yield merely because one PR merged. Auto-merge remains opt-in and may be enabled only when the user has explicitly requested it.
341+
6. **Continuous maintenance mode:** When the user explicitly asks for autonomous continuation, refresh the open issue/PR queue after cleanup, select the highest-impact ready issue with no overlapping PR, and restart the Development Phase. Do not yield merely because one PR merged. Auto-merge remains opt-in and may be enabled only when the user has explicitly requested it.
340342

341343
---
342344

0 commit comments

Comments
 (0)