Feature Overview
Currently, the PEI Core instance of AdvancedLoggerLib relies on hacking the PEI_CORE_INSTANCE to have a stack based pointer to the advanced logger buffer. This avoids a HOB lookup on every log message. The lib instance uses PeiMain.h to have the definition of the structure.
However, mu_basecore has been updated to include an edk2 change that added a private header to PeiMain.h (which is private but not enforced so by the build system), which breaks the builds. In response, a temporary workaround was added to force include this private header.
Solution Overview
The hack of using PEI_CORE_INSTANCE can be dropped entirely and a separate scratchpad space can be used to avoid the HOB lookup.
Alternatives Considered
No response
Urgency
Medium
Are you going to implement the feature request?
I will implement the feature
Do you need maintainer feedback?
No maintainer feedback needed
Anything else?
No response
Feature Overview
Currently, the PEI Core instance of AdvancedLoggerLib relies on hacking the PEI_CORE_INSTANCE to have a stack based pointer to the advanced logger buffer. This avoids a HOB lookup on every log message. The lib instance uses PeiMain.h to have the definition of the structure.
However, mu_basecore has been updated to include an edk2 change that added a private header to PeiMain.h (which is private but not enforced so by the build system), which breaks the builds. In response, a temporary workaround was added to force include this private header.
Solution Overview
The hack of using PEI_CORE_INSTANCE can be dropped entirely and a separate scratchpad space can be used to avoid the HOB lookup.
Alternatives Considered
No response
Urgency
Medium
Are you going to implement the feature request?
I will implement the feature
Do you need maintainer feedback?
No maintainer feedback needed
Anything else?
No response