CHORE: Flaky Setup - Gate benchmark and baseline steps on job success (#724)

### Work Item / Issue Reference

> ADO Work Item: Fixed
[AB#47384](https://sqlclientdrivers.visualstudio.com/c6d89619-62de-46a0-8b46-70b92a84d85e/_workitems/edit/47384)

-------------------------------------------------------------------
### Summary

the benchmark and baseline steps keep running after SQL Server setup has
already failed, so a dead job still burns 20 minutes benchmarking
against a database that does not exist.

build 167929, `macOS x86_64 SQL2025`:

Build + start SQL Server (Colima boot & SQL setup...) failed 15.6 min
    Install mssql_py_core from NuGet wheels                 skipped
    Uninstall system ODBC Driver before running tests       skipped
    Run pytest with coverage                                skipped
Download and restore AdventureWorks2022 database succeeded 0.4 min
Download macOS baseline from main succeeded 0.0 min
Prepare macOS baseline file succeeded 0.0 min
Run performance benchmarks on macOS SQL2025 succeededWithIssues 20.2 min

pytest was correctly skipped because it relies on the default step
condition. the four that ran override it:

condition: or(eq(variables['sqlVersion'], 'SQL2022'),
eq(variables['sqlVersion'], 'SQL2025'))

that only asks which SQL version the leg is. writing an explicit
condition replaces the implicit `succeeded()` rather than adding to it,
so nothing upstream is checked. `Publish macOS benchmark baseline`
already had this right with `and(succeeded(), ...)`.

each condition now starts with `succeeded()`. the windows leg has the
same four steps with the same pattern, and its SQL setup steps carry no
`continueOnError`, so a failure there propagates the same way. eight
sites in total across `pytestonwindows` and `PytestOnMacOS`.

the benchmark step also carries `timeoutInMinutes: 20` and
`continueOnError: true`, so when it times out the job reports
`succeededWithIssues` instead of failing. the macOS SQL2022 leg in that
same build finished `succeededWithIssues` for exactly that reason. this
does not change that behaviour, it just stops the step running when
there is nothing to benchmark against.

related to
[AB#47311](https://sqlclientdrivers.visualstudio.com/c6d89619-62de-46a0-8b46-70b92a84d85e/_workitems/edit/47311).
that one raised the macOS job timeout to 90 minutes, this one stops a
failed setup from eating 20 minutes of the budget.

---------

Co-authored-by: Gaurav Sharma <223556219+Copilot@users.noreply.github.com>

Author: bewithgaurav

eng/pipelines/pr-validation-pipeline.yml

@@ -238,23 +238,23 @@ jobs:
   - script: |
       python -m pytest -v --junitxml=test-results-localdb.xml --cov=. --cov-report=xml:coverage-localdb.xml --capture=tee-sys --cache-clear
     displayName: 'Run tests with coverage on LocalDB'
-    condition: eq(variables['sqlVersion'], 'LocalDB')
+    condition: and(succeeded(), eq(variables['sqlVersion'], 'LocalDB'))
     env:
       DB_CONNECTION_STRING: 'Server=(localdb)\MSSQLLocalDB;Database=TestDB;Uid=testuser;Pwd=$(DB_PASSWORD);TrustServerCertificate=yes'
 
   # Run tests for SQL Server 2022
   - script: |
       python -m pytest -v --junitxml=test-results-sql2022.xml --cov=. --cov-report=xml:coverage-sql2022.xml --capture=tee-sys --cache-clear
     displayName: 'Run tests with coverage on SQL Server 2022'
-    condition: eq(variables['sqlVersion'], 'SQL2022')
+    condition: and(succeeded(), eq(variables['sqlVersion'], 'SQL2022'))
     env:
       DB_CONNECTION_STRING: 'Server=localhost;Database=TestDB;Uid=testuser;Pwd=$(DB_PASSWORD);TrustServerCertificate=yes'
 
   # Run tests for SQL Server 2025
   - script: |
       python -m pytest -v --junitxml=test-results-sql2025.xml --cov=. --cov-report=xml:coverage-sql2025.xml --capture=tee-sys --cache-clear
     displayName: 'Run tests with coverage on SQL Server 2025'
-    condition: eq(variables['sqlVersion'], 'SQL2025')
+    condition: and(succeeded(), eq(variables['sqlVersion'], 'SQL2025'))
     env:
       DB_CONNECTION_STRING: 'Server=localhost;Database=TestDB;Uid=testuser;Pwd=$(DB_PASSWORD);TrustServerCertificate=yes'
 
@@ -292,7 +292,7 @@ jobs:
         exit 1
       }
     displayName: 'Download and restore AdventureWorks2022 database'
-    condition: or(eq(variables['sqlVersion'], 'SQL2022'), eq(variables['sqlVersion'], 'SQL2025'))
+    condition: and(succeeded(), or(eq(variables['sqlVersion'], 'SQL2022'), eq(variables['sqlVersion'], 'SQL2025')))
     env:
       DB_PASSWORD: $(DB_PASSWORD)
 
@@ -307,7 +307,7 @@ jobs:
       artifact: 'perf-baseline-$(sqlVersion)'
       path: $(Build.SourcesDirectory)
     displayName: 'Download baseline from main'
-    condition: and(ne(variables['Build.SourceBranch'], 'refs/heads/main'), or(eq(variables['sqlVersion'], 'SQL2022'), eq(variables['sqlVersion'], 'SQL2025')))
+    condition: and(succeeded(), ne(variables['Build.SourceBranch'], 'refs/heads/main'), or(eq(variables['sqlVersion'], 'SQL2022'), eq(variables['sqlVersion'], 'SQL2025')))
     continueOnError: true
 
   # Rename downloaded baseline so the script finds it (artifact may be in a subfolder)
@@ -320,7 +320,7 @@ jobs:
         Write-Host "No baseline file downloaded (first run or artifact missing)"
       }
     displayName: 'Prepare baseline file'
-    condition: and(ne(variables['Build.SourceBranch'], 'refs/heads/main'), or(eq(variables['sqlVersion'], 'SQL2022'), eq(variables['sqlVersion'], 'SQL2025')))
+    condition: and(succeeded(), ne(variables['Build.SourceBranch'], 'refs/heads/main'), or(eq(variables['sqlVersion'], 'SQL2022'), eq(variables['sqlVersion'], 'SQL2025')))
     continueOnError: true
 
   # Run performance benchmarks on SQL Server 2022
@@ -412,7 +412,7 @@ jobs:
       Write-Host "`nRunning performance benchmarks..."
       python benchmarks/perf-benchmarking.py --baseline benchmark_baseline.json --json benchmark_results.json
     displayName: 'Run performance benchmarks on SQL Server 2022/2025'
-    condition: or(eq(variables['sqlVersion'], 'SQL2022'), eq(variables['sqlVersion'], 'SQL2025'))
+    condition: and(succeeded(), or(eq(variables['sqlVersion'], 'SQL2022'), eq(variables['sqlVersion'], 'SQL2025')))
     continueOnError: true
     env:
       DB_CONNECTION_STRING: 'Server=localhost;Database=AdventureWorks2022;Uid=sa;Pwd=$(DB_PASSWORD);TrustServerCertificate=yes'
@@ -672,7 +672,7 @@ jobs:
       rm -f /tmp/AdventureWorks2022.bak
       docker exec sqlserver rm -f /tmp/AdventureWorks2022.bak || true
     displayName: 'Download and restore AdventureWorks2022 database on macOS'
-    condition: or(eq(variables['sqlVersion'], 'SQL2022'), eq(variables['sqlVersion'], 'SQL2025'))
+    condition: and(succeeded(), or(eq(variables['sqlVersion'], 'SQL2022'), eq(variables['sqlVersion'], 'SQL2025')))
     continueOnError: true
     env:
       DB_PASSWORD: $(DB_PASSWORD)
@@ -688,7 +688,7 @@ jobs:
       artifact: 'perf-baseline-macOS-$(sqlVersion)'
       path: $(Build.SourcesDirectory)
     displayName: 'Download macOS baseline from main'
-    condition: and(ne(variables['Build.SourceBranch'], 'refs/heads/main'), or(eq(variables['sqlVersion'], 'SQL2022'), eq(variables['sqlVersion'], 'SQL2025')))
+    condition: and(succeeded(), ne(variables['Build.SourceBranch'], 'refs/heads/main'), or(eq(variables['sqlVersion'], 'SQL2022'), eq(variables['sqlVersion'], 'SQL2025')))
     continueOnError: true
 
   - script: |
@@ -700,7 +700,7 @@ jobs:
         echo "No baseline file downloaded (first run or artifact missing)"
       fi
     displayName: 'Prepare macOS baseline file'
-    condition: and(ne(variables['Build.SourceBranch'], 'refs/heads/main'), or(eq(variables['sqlVersion'], 'SQL2022'), eq(variables['sqlVersion'], 'SQL2025')))
+    condition: and(succeeded(), ne(variables['Build.SourceBranch'], 'refs/heads/main'), or(eq(variables['sqlVersion'], 'SQL2022'), eq(variables['sqlVersion'], 'SQL2025')))
     continueOnError: true
 
   # Run performance benchmarks on macOS
@@ -714,7 +714,7 @@ jobs:
       echo "Running performance benchmarks..."
       python benchmarks/perf-benchmarking.py --baseline benchmark_baseline.json --json benchmark_results.json
     displayName: 'Run performance benchmarks on macOS $(sqlVersion)'
-    condition: or(eq(variables['sqlVersion'], 'SQL2022'), eq(variables['sqlVersion'], 'SQL2025'))
+    condition: and(succeeded(), or(eq(variables['sqlVersion'], 'SQL2022'), eq(variables['sqlVersion'], 'SQL2025')))
     timeoutInMinutes: 20
     continueOnError: true
     env:
@@ -963,7 +963,7 @@ jobs:
         "
       fi
     displayName: 'Run pytest with coverage in $(distroName) container'
-    condition: or(eq(variables['useAzureSQL'], 'false'), and(eq(variables['useAzureSQL'], 'true'), ne(variables['AZURE_CONNECTION_STRING'], '')))
+    condition: and(succeeded(), or(eq(variables['useAzureSQL'], 'false'), and(eq(variables['useAzureSQL'], 'true'), ne(variables['AZURE_CONNECTION_STRING'], ''))))
     env:
       DB_PASSWORD: $(DB_PASSWORD)
 
@@ -995,7 +995,7 @@ jobs:
         docker exec sqlserver-$(distroName) rm -f /tmp/AdventureWorks2022.bak || true
       fi
     displayName: 'Download and restore AdventureWorks2022 database in $(distroName)'
-    condition: and(eq(variables['distroName'], 'Ubuntu'), eq(variables['useAzureSQL'], 'false'))
+    condition: and(succeeded(), eq(variables['distroName'], 'Ubuntu'), eq(variables['useAzureSQL'], 'false'))
     continueOnError: true
     env:
       DB_PASSWORD: $(DB_PASSWORD)
@@ -1052,7 +1052,7 @@ jobs:
         echo "Skipping performance benchmarks on $(distroName) (only runs on Ubuntu with local SQL Server)"
       fi
     displayName: 'Run performance benchmarks in $(distroName) container'
-    condition: and(eq(variables['distroName'], 'Ubuntu'), eq(variables['useAzureSQL'], 'false'))
+    condition: and(succeeded(), eq(variables['distroName'], 'Ubuntu'), eq(variables['useAzureSQL'], 'false'))
     continueOnError: true
     env:
       DB_PASSWORD: $(DB_PASSWORD)