Mark data-backed record variables async#3073
Open
jaemin-capslock wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
lesaltzm
requested changes
Jun 8, 2026
| { | ||
| if (dataSource.RequiresAsync) | ||
| { | ||
| return true; |
Contributor
There was a problem hiding this comment.
that's definitely not right. Almost every type from a data source will have an associated data source marked as requires async.
|
|
||
| // Any connectedDataSourceInfo or option set or view needs to be accessed asynchronously to allow data to be loaded. | ||
| IsAsync = Data is IExternalTabularDataSource || Kind == BindKind.OptionSet || Kind == BindKind.View || isAsync; | ||
| IsAsync = Data is IExternalTabularDataSource || Kind == BindKind.OptionSet || Kind == BindKind.View || isAsync || TypeRequiresAsync(kind, type, data); |
Contributor
There was a problem hiding this comment.
are you sure it's not just that we're missing OptionSetValue in this list?
Contributor
There was a problem hiding this comment.
or that specifically coercion from an optionset value to a string should be marked as async?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assume a case where
App.OnStart= Set(varAccount, First(Accounts)
Toggle1.Default=Coalesce(varAccount.'Option set', false)
The emitted
Rule.IsAsyncwas false because pfx interpretedvarAccount.'Option set'as a synchronous variable lookup, which depends on the datasourceAccounts. As line 44 in NameLookupInfo.cs states, they should have been accessed async, hence Rule.IsAsync should have been true.This caused issues in Powerapps. Emitted rule had
IsAsync: False, so it translated that as synchronous js code. But the argument was actually async, which meant we were passing aPromiseto a sync js function.