Skip to content

Commit 317d93f

Browse files
authored
chore(dedup): bump shaded jacoco.core to 0.8.15 to raise the Java ceiling (#186)
The ASM shaded into keploy-sdk.jar comes from this dependency, and it is an independent ceiling on the bytecode dynamic dedup can instrument — separate from the jacocoagent.jar in k8s-proxy's init image. While it sat on 0.8.12 it was the LOWER of the two, so it, not the agent, is what capped dedup at Java 22. Measured by building this module both ways and reading the shaded ASM out of each jar: jacoco.core 0.8.12 -> ASM declares V23 (JaCoCo officially supports Java 22) jacoco.core 0.8.15 -> ASM declares V27 (JaCoCo officially supports Java 26) The 0.8.12 row reproduces the "tops out at Opcodes.V23" note k8s-proxy carried, and shows why it was read one version too high: the highest version ASM DECLARES is its experimental one, which sits a release ahead of what it accepts by default. With this, the SDK's shaded ASM matches the agent's (both V27 / Java 26), so once a release carrying it is pinned as KEPLOY_SDK_VERSION, k8s-proxy can raise dedupinject.SDKShadedASMMaxJava to 26 and the effective ceiling — min(JaCoCoOfficialMaxJava, SDKShadedASMMaxJava) — becomes Java 26. Build and the module's tests pass unchanged against 0.8.15. Signed-off-by: Shubham Jain <shubham@keploy.io>
1 parent 87a449c commit 317d93f

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

‎keploy-sdk/pom.xml‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,12 @@
6262
<dependency>
6363
<groupId>org.jacoco</groupId>
6464
<artifactId>org.jacoco.core</artifactId>
65-
<version>0.8.12</version>
65+
<!-- Keep in step with k8s-proxy dedupinject.BundledJaCoCoVersion: this
66+
dependency is what shades ASM into keploy-sdk.jar, and that shaded
67+
ASM is an independent ceiling on the Java bytecode dynamic dedup can
68+
instrument. While this sat on 0.8.12 it, not the jacocoagent in the
69+
init image, was what capped dedup at Java 22. -->
70+
<version>0.8.15</version>
6671
</dependency>
6772
<dependency>
6873
<groupId>com.kohlschutter.junixsocket</groupId>

0 commit comments

Comments
 (0)