Skip to content

DropObject.Sort is done too early in SchemaInstaller.Install #49

Description

@jeroenbu

Hi,

In Insight.Database.Schema.SchemaInstaller context.DropObjects.Sort((e1, e2) => -CompareByInstallOrder(e1, e2)); is done too early. Right now the DropObjects are sorted, and in the codeblock for anything that's not entirely new the DropObject collection can be modified, resulting in a possible incorrect sortorder.
Solution is to place the DropObject.Sort on a line following the code block for anything that's not entirely new; right next to the sort of the AddObject will do just fine.

Thx,

Jeroen

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions