PurchaseOrder PATCH accepts status_custom_key, but does not persist valid custom status

[johnluetke]

Please verify that this bug has NOT been raised before.

• I checked and didn't find a similar issue

Describe the bug*

PATCH /api/order/po/{id}/ appears to accept status_custom_key, but a valid custom status is not persisted.

Steps to Reproduce

1. Confirm custom PO status exists via API: GET /api/generic/status/custom/?reference_status=PurchaseOrderStatus

[
  {
    "key": 110,
    "name": "NEEDS_APPROVAL",
    "label": "Needs Approval",
    "logical_key": 10,
    "reference_status": "PurchaseOrderStatus"
  }
]

2. Confirm target PurchaseOrder is has correct logical status.

{
  "pk": 282,
  "status": 10,
  "status_text": "Pending",
  "status_custom_key": 10
}

3. PATCH with valid custom key for the current logicial status

curl --request PATCH \
  --url https://<host>/api/order/po/282/ \
  --header 'Authorization: Token <redacted>' \
  --header 'Content-Type: application/json' \
  --data '{
    "status_custom_key": 110
  }'

Expected behaviour

status_custom_key should persist.

{
  "status": 10,
  "status_custom_key": 110
}

Deployment Method

None

Version Information

Inventree version 1.3.2
API version 477
Python 3.14.3
Django 5.2.13
Commit Hash a60e85b

Try to reproduce on the demo site

I tried to reproduce

Is the bug reproducible on the demo site?

Reproducible

Relevant log output

[SchrodingersGat]

@johnluetke I do not think that we have considered patching the custom status key in this manner.

@matmair any thoughts on this? Should we allow arbitrary changes of the custom status values (as long as they align with the current logical status)? I think that this is acceptable, but not currently supported via the API

[matmair]

I think it makes sense to accept changes but there needs to be validation that they align with the logical state.

[johnluetke]

Thanks, I didn't think I was attempting to do something uncommon, as I couldn't find a way to set the PO status to one of the custom-defined values outside of the Django backend interface. Is there something I missed in that regard?

[SchrodingersGat]

Is there something I missed in that regard?

No, it's just not implemented via the API. We would happily accept a patch to fix the behaviour you have reported here :)

[johnluetke]

Great! My python is little rusty, but I'll see what I can do!