set_last_advertised_time() should be hidden from user

[skonefal]

last_advertised_time is Snap internal data and I'm not sure that it should be exposed to user changes.

[wejohnson-zz]

set_last_advertised_time() calls a private method that sets the time. Are you saying the user should not be able to set the last advertised time at all?

[mkleina]

I think that @skonefal is right, we should be consistent with Go library, and in Go library lastAdvertisedTime is provate field, passed only for legacy reasons: https://github.com/intelsdi-x/snap-plugin-lib-go/blob/d1d32a057c0c23169796016876ce89634b2c012f/v1/plugin/metric.go#L40

[skonefal]

I might be wrong, but Last Advertised Time is something that Snap Framework should set. Framework (snapteld) knows when metrics was last advertised by plugin and should set it accordingly. The less knobs user can set, the easier it will be to write plugins.