fix(sdk): Log full resource on cleanup failure

Log the discovered resource body when a cleanup delete fails and
dump failed resources in the functional test assertion. Resources are
gone by the time CI output is read, so device_owner and similar
details were not recoverable when e.g. a port delete was denied by
policy.

Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>

Author: gtema

openstack_sdk/src/cleanup/engine.rs

@@ -307,6 +307,18 @@ impl<'a> ProjectCleanup<'a> {
                         result.deleted_ids.push(resource.id.clone());
                     }
                     Err(e) => {
+                        // Log the full resource body: the failure message
+                        // alone rarely says why (e.g. which `device_owner`
+                        // a policy-denied port had), and the resource is
+                        // usually gone by the time anyone investigates.
+                        tracing::warn!(
+                            kind = ?resource.kind,
+                            id = %resource.id,
+                            reason = ?resource.reason,
+                            raw = %resource.raw,
+                            error = %e,
+                            "cleanup delete failed"
+                        );
                         result.errors.push((resource.id.clone(), e.to_string()));
                         for &parent_idx in &blocks_parents_of[idx] {
                             blocked[parent_idx] = true;

openstack_sdk/tests/cleanup/full_scenario.rs

@@ -193,12 +193,20 @@ async fn cleanup_engine_removes_related_resources_across_all_services()
         .discover(std::collections::HashMap::new(), Some(eval))
         .await
         .expect("discover failed");
+    let planned_nodes = plan.nodes.clone();
     let result = cleanup.apply(plan).await.expect("apply failed");
 
+    // Resources are gone by the time CI output is read, so dump the full
+    // body of every resource that failed to delete.
+    let failed_resources: Vec<_> = planned_nodes
+        .iter()
+        .filter(|n| result.errors.iter().any(|(id, _)| id == &n.id))
+        .collect();
     assert!(
         result.errors.is_empty(),
-        "unexpected cleanup errors: {:?}",
-        result.errors
+        "unexpected cleanup errors: {:?}\nfailed resources: {:#?}",
+        result.errors,
+        failed_resources
     );
 
     for id in [