Skip to content

Inconsistency in handling of JIT variants in solver tests #1067

@tm91236

Description

@tm91236

What's the issue?

In SolverTest the check_solution_invariants method compares the coreset to the result of a call to solver.reduce or solver.refine. The passed coreset may have been computed with jit_variant(solver.reduce) while the call in check_solution_invariants is always computed without JIT transformation. However, we cannot be sure that jit_variant(solver.reduce)(...) == solver.reduce(...), due to slight numerical differences that can manifest from JIT transformation. While this doesn't cause us any problems at the moment, it could be a source of future (device dependent) test failures.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions