Visual Studio 2017 support

[ForNeVeR]

Now, after VS2017 release, we can see what have been done there, and what haven't been done.

I have been using EditorConfig for Visual Studio to consistently set the following properties on my projects:

[*]
charset = utf-8 # that means without BOM
indent_style = space
indent_size = 4
insert_final_newline = true
trim_trailing_whitespace = true

VS2017 doesn't support charset = utf-8 (and forces the BOM all the way), nor insert_final_newline neither trim_trailing_whitespace, and that causes mess in my sources. The kind of mess I'd like to exterminate.

I think that embedded EditorConfig support in VS2017 isn't very useful in its current state, and I'd like the plugin to be resurrected and released for VS2017.

[Denis535]

Are embedded EditorConfig plugin and this plugin different plugins?

[jednano]

Yes, quite.

[enlight]

Supposedly insert_final_newline and trim_trailing_whitespace are supported in the VS2017 15.3 (currently in preview). Alas I've discovered after some frustration that VS2017 15.2 also doesn't support tab_width, but at least that's easy to get around by setting indent_size instead.

[mihaipopescu]

I'd adhere also to a way to disable VS2017 "native" support (or for Microsoft just to fix it) and put the extension back on the marketplace. We're waiting for utf-8 bugfix to be available in VS2017.

[whyleee]

Another problem with VS2017 that it doesn't support end_of_line = lf correctly - it always creates files with CRLF endlines 😕

[mihaipopescu]

really? for any type of file? are you sure it's not your repo setting who is messing with eol's?

[bkaradzic]

MS VS2017 support is really jenky (at least with C++ projects). I just switched to VS2017 from VS2015 and EditorConfig is mixing tabs/spaces. It seems it's getting confused with multiple .editorconfig that have different settings. This worked fine with plugin in previous versions of VS.

[KindDragon]

Please report this bug to them with a description your .editorconfig files and where they stored
https://developercommunity.visualstudio.com/spaces/8/index.html

[bkaradzic]

Uh... I'm reporting it here because I don't believe MS is capable of maintaining it. Old plugin just worked fine, no issues for years and multiple versions of VS, and then MS takes it over and breaks it. Obviously they were incompetent to integrate fully working VS plugin into VS.

[KindDragon]

But no one maintains this extension anymore...

[mihaipopescu]

Then let's just close the issue. It's a Vistual Studio issue and we should open it on their side.

[binki]

@mihaipopescu @whyleee References for the end_of_line=lf issues:

• Typing /// in C# file results in CRLF being used for the lines with the generated comment: Comment templates doesn't respect end_of_line = lf in .editorconfig dotnet/roslyn#23143 (originally https://developercommunity.visualstudio.com/content/problem/144281/comment-templates-doesnt-respect-end-of-line-lf-in.html)
• Creating a non-C# file from a template, e.g. an XML file, results in the file being in CRLF mode even though end_of_line=lf but insert_final_newline=true adds an LF instead of CRLF to the end of the file, creating a mixed file: https://developercommunity.visualstudio.com/content/problem/277772/editorconfig-bad-interaction-bewteen-end-of-linelf.html (originally editorconfig: Bad interaction between end_of_line=lf and insert_final_newline=true with CRLF templates in VS dotnet/roslyn#28027)

[mihaipopescu]

I just tested in VS2017 v15.8.9:

[*]
charset = utf-8                  # FIXED
insert_final_newline = true      # FIXED
trim_trailing_whitespace = true  # NOT FIXED

[ziriax]

I just tested in VS2017 v15.8.9:

[*]
charset = utf-8                  # FIXED
insert_final_newline = true      # FIXED
trim_trailing_whitespace = true  # NOT FIXED

end_of_line = lf # NOT FIXED

I am currently getting different things that are not working for me as well.

csharp_space_after_comma = true:warning # NOT WORKING