Skip to content

fix(ci): force @semantic-release/npm@13 to fix trusted publishing#1172

Merged
andrejak merged 1 commit into
mainfrom
andreja/tsp-1427-fix-trusted-publishing-nested-plugin
Jun 9, 2026
Merged

fix(ci): force @semantic-release/npm@13 to fix trusted publishing#1172
andrejak merged 1 commit into
mainfrom
andreja/tsp-1427-fix-trusted-publishing-nested-plugin

Conversation

@andrejak

@andrejak andrejak commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Follow-up fix for TSP-1427. The initial trusted-publishing change (#1171) failed on main with ENONPMTOKEN.

Root cause: semantic-release@24 declares a dependency on @semantic-release/npm@^12 (no OIDC support) and loaded that nested copy from node_modules/semantic-release/node_modules/@semantic-release/npm instead of the top-level 13.1.5 we added as a direct devDependency. The v12 plugin still requires a long-lived NPM_TOKEN.

This pins @semantic-release/npm to 13.1.5 via resolutions, so the OIDC-capable plugin is used everywhere and the nested v12 copy is removed.

Test plan

  • yarn install --immutable passes
  • Verified the nested @semantic-release/npm@12.0.2 is gone; only top-level 13.1.5 remains
  • Tests + build pass (pre-commit hook)
  • Confirm the trusted publisher is configured on npmjs.com for @duffel/api (owner duffelhq, repo duffel-api-javascript, workflow release.yml) so the OIDC token exchange succeeds
  • Verify a successful release publishes to npm from main

Made with Cursor

semantic-release@24 bundles @semantic-release/npm@12 (no OIDC support),
which was loaded from its nested node_modules instead of our top-level
v13, causing publishing to fail with ENONPMTOKEN. Pin v13.1.5 via
resolutions so the OIDC-capable plugin is used everywhere.

Co-authored-by: Cursor <cursoragent@cursor.com>
@andrejak andrejak marked this pull request as ready for review June 9, 2026 12:28
@andrejak andrejak requested a review from a team as a code owner June 9, 2026 12:28
@andrejak andrejak merged commit 6cf8cb2 into main Jun 9, 2026
5 checks passed
@andrejak andrejak deleted the andreja/tsp-1427-fix-trusted-publishing-nested-plugin branch June 9, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants