Skip to content

Commit db9e2cc

Browse files
devantlerclaude
andauthored
fix(deploy): set ProviderConfig secretRef.namespace (required field) (#42)
The namespaced github.m.upbound.io ProviderConfig still requires spec.credentials.secretRef.namespace (the CRD enforces it); omitting it made the platform tenant's Flux apply fail dry-run, blocking the whole artifact (ExternalSecret + ProviderConfig + Repository MRs). secretRef.namespace is a value, not the resource namespace, so targetNamespace can't inject it — set it explicitly to github-config where the credential Secret is materialized. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent fc63c75 commit db9e2cc

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

‎deploy/provider-config.yaml‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,13 @@
22
# against the devantler-tech org as a GitHub App. Tenant-owned (applied by the
33
# github-config app's ServiceAccount). It is referenced by the namespaced
44
# Repository/… managed resources in this same namespace. The credentials Secret
5-
# is local (same namespace), materialized by external-secret.yaml from OpenBao.
6-
# namespace is omitted on purpose — the platform tenant Kustomization injects it
7-
# via targetNamespace (= github-config). The github.m.upbound.io CRD is installed
8-
# by the provider package (platform infrastructure layer).
5+
# is materialized by external-secret.yaml from OpenBao.
6+
#
7+
# The resource's own namespace is omitted on purpose — the platform tenant
8+
# Kustomization injects it via targetNamespace (= github-config). But
9+
# spec.credentials.secretRef.namespace is a REQUIRED field (the CRD enforces it
10+
# even for a namespaced ProviderConfig) and is a value, not the resource
11+
# namespace, so it must be set explicitly to where the credential Secret lives.
912
apiVersion: github.m.upbound.io/v1beta1
1013
kind: ProviderConfig
1114
metadata:
@@ -14,5 +17,6 @@ spec:
1417
credentials:
1518
source: Secret
1619
secretRef:
20+
namespace: github-config
1721
name: github-app-credentials
1822
key: credentials

0 commit comments

Comments
 (0)