Skip to content

Commit ad79d8a

Browse files
rfayclaude
andcommitted
fix(docs-issue-picker): stop prescribing an unverified fork-creation flow
The "no issue fork exists" message asserted a drupal.org-specific "Get push access" button regardless of source, which is wrong for GitLab-native issues (e.g. media_image_metadata/-/work_items/3558227) and not something this tool verifies either way. It only needs to report that no fork exists and point at the issue. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent 1b08f15 commit ad79d8a

1 file changed

Lines changed: 9 additions & 12 deletions

File tree

‎docs/drupal-issue.html‎

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,7 @@ <h2 id="workspace-names">Workspace name</h2>
476476
<p>A suggested workspace name is auto-generated from the parameters above. It may be changed before clicking launch.</p>
477477

478478
<h2 id="issue-forks">Issue forks</h2>
479-
<p>An issue fork must already exist on <a class="cds-link" href="https://git.drupalcode.org">git.drupalcode.org</a> — use <strong>Get push access</strong> on the drupal.org issue to create one, then reload here.</p>
479+
<p>An issue fork must already exist on <a class="cds-link" href="https://git.drupalcode.org">git.drupalcode.org</a> before it shows up here. For issues still on drupal.org, use <strong>Get push access</strong> on the issue page to create one. For projects whose issue queue has migrated to GitLab, create the fork from the issue's GitLab page instead — then reload here.</p>
480480
<p>Issue fork workspaces always run a full <code>ddev drush si</code> so the checked-out branch matches the running site (not a stale snapshot).</p>
481481
</section>
482482

@@ -793,17 +793,14 @@ <h2 id="feedback">Feedback &amp; Community</h2>
793793
: 'https://www.drupal.org/project/' + projectName + '/issues/' + nid;
794794

795795
if (branchResp.status === 404) {
796-
if (currentIsContrib) {
797-
setStatus(
798-
'No issue fork exists for #' + nid + ' on ' + projectName + ' yet. Visit the issue page and click "Get push access" to create a fork, then come back here.',
799-
'info'
800-
);
801-
} else {
802-
setStatus(
803-
'No issue fork exists for #' + nid + ' yet. To work on this issue, visit the issue page and click "Get push access" to create a fork, then come back here.',
804-
'info'
805-
);
806-
}
796+
// This tool works with an existing issue fork; it doesn't create one, and
797+
// the actual "create a fork" mechanism differs between drupal.org and
798+
// GitLab-native issues (and we can't reliably assert either UI's exact
799+
// steps here) — so just report the fact and point at the issue itself.
800+
setStatus(
801+
'No issue fork exists yet for #' + nid + ' on ' + projectName + ': ' + issuePageUrl,
802+
'info'
803+
);
807804
return;
808805
}
809806
if (!branchResp.ok) throw new Error('git.drupalcode.org API returned ' + branchResp.status);

0 commit comments

Comments
 (0)