Skip to content

Commit 80f4316

Browse files
committed
follow-up ruff upgrade
1 parent 4961686 commit 80f4316

4 files changed

Lines changed: 19 additions & 11 deletions

File tree

pyproject.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ lint.ignore = [
116116
"C408",
117117
"C901",
118118
"COM812",
119+
"CPY001",
119120
"EM101",
120121
"EM103",
121122
"FBT002",
@@ -148,3 +149,6 @@ lint.ignore = [
148149
line-length = 120
149150
target-version = "py310"
150151
exclude = ["doc", "example*.py", "tests/examples/*.py"]
152+
153+
[tool.ruff.lint.pylint]
154+
max-positional-args = 10

pytest_httpserver/blocking_httpserver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ def assert_request(
7676
data: str | bytes | None = None,
7777
data_encoding: str = "utf-8",
7878
headers: Mapping[str, str] | None = None,
79-
query_string: None | QueryMatcher | str | bytes | Mapping[str, str] = None,
79+
query_string: QueryMatcher | str | bytes | Mapping[str, str] | None = None,
8080
header_value_matcher: HeaderValueMatcher | None = None,
8181
json: Any = UNDEFINED,
8282
timeout: int = 30,

pytest_httpserver/httpserver.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ def get_comparing_values(self, request_query_string: bytes) -> tuple[bool, bool]
265265
return (True, False)
266266

267267

268-
def _create_query_matcher(query_string: None | QueryMatcher | str | bytes | Mapping[str, str]) -> QueryMatcher:
268+
def _create_query_matcher(query_string: QueryMatcher | str | bytes | Mapping[str, str] | None) -> QueryMatcher:
269269
if isinstance(query_string, QueryMatcher):
270270
return query_string
271271

@@ -300,7 +300,7 @@ class RequestMatcherKwargs(TypedDict, total=False):
300300
data: str | bytes | None
301301
data_encoding: str
302302
headers: Mapping[str, str] | None
303-
query_string: None | QueryMatcher | str | bytes | Mapping[str, str]
303+
query_string: QueryMatcher | str | bytes | Mapping[str, str] | None
304304
header_value_matcher: HVMATCHER_T | None
305305
json: Any
306306

@@ -341,7 +341,7 @@ def __init__(
341341
data: str | bytes | None = None,
342342
data_encoding: str = "utf-8",
343343
headers: Mapping[str, str] | None = None,
344-
query_string: None | QueryMatcher | str | bytes | Mapping[str, str] = None,
344+
query_string: QueryMatcher | str | bytes | Mapping[str, str] | None = None,
345345
header_value_matcher: HVMATCHER_T | None = None,
346346
json: Any = UNDEFINED,
347347
) -> None:
@@ -1068,7 +1068,7 @@ def expect_request(
10681068
data: str | bytes | None = None,
10691069
data_encoding: str = "utf-8",
10701070
headers: Mapping[str, str] | None = None,
1071-
query_string: None | QueryMatcher | str | bytes | Mapping[str, str] = None,
1071+
query_string: QueryMatcher | str | bytes | Mapping[str, str] | None = None,
10721072
header_value_matcher: HVMATCHER_T | None = None,
10731073
handler_type: HandlerType = HandlerType.PERMANENT,
10741074
json: Any = UNDEFINED,
@@ -1151,7 +1151,7 @@ def expect_oneshot_request(
11511151
data: str | bytes | None = None,
11521152
data_encoding: str = "utf-8",
11531153
headers: Mapping[str, str] | None = None,
1154-
query_string: None | QueryMatcher | str | bytes | Mapping[str, str] = None,
1154+
query_string: QueryMatcher | str | bytes | Mapping[str, str] | None = None,
11551155
header_value_matcher: HVMATCHER_T | None = None,
11561156
json: Any = UNDEFINED,
11571157
) -> RequestHandler:
@@ -1206,7 +1206,7 @@ def expect_ordered_request(
12061206
data: str | bytes | None = None,
12071207
data_encoding: str = "utf-8",
12081208
headers: Mapping[str, str] | None = None,
1209-
query_string: None | QueryMatcher | str | bytes | Mapping[str, str] = None,
1209+
query_string: QueryMatcher | str | bytes | Mapping[str, str] | None = None,
12101210
header_value_matcher: HVMATCHER_T | None = None,
12111211
json: Any = UNDEFINED,
12121212
) -> RequestHandler:

tests/test_log_querying.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,10 @@ def test_verify_assert_msg(httpserver: HTTPServer):
4040

4141
expected_lines = [
4242
"Matching request found 0 times but expected 1 times.",
43-
"Expected request: <RequestMatcher uri='/foo' method='POST' query_string=None headers={} data"
44-
"=None json={'foo': 'bar'}>",
43+
(
44+
"Expected request: <RequestMatcher uri='/foo' method='POST' query_string=None headers={} data"
45+
"=None json={'foo': 'bar'}>"
46+
),
4547
"Found 1 similar request(s):",
4648
"--- Similar Request Start",
4749
"Path: /foo",
@@ -70,8 +72,10 @@ def test_verify_assert_msg_no_similar_requests(httpserver: HTTPServer):
7072

7173
expected_lines = [
7274
"Matching request found 0 times but expected 1 times.",
73-
"Expected request: <RequestMatcher uri='/foo' method='POST' query_string=None headers={} data"
74-
"=None json={'foo': 'bar'}>",
75+
(
76+
"Expected request: <RequestMatcher uri='/foo' method='POST' query_string=None headers={} data"
77+
"=None json={'foo': 'bar'}>"
78+
),
7579
"No similar requests found.",
7680
]
7781

0 commit comments

Comments
 (0)