fix(ci): unblock typecheck and destructive test gate

typecheck imports examples through @corbits/artifacts dist types, so
build first. Wire ALLOW_DESTRUCTIVE_ARTIFACT_TESTS=1 into CI so the
TRUNCATE/DROP gate the suite now enforces can actually run. Align the
reference-host decorate callback with the readonly base row type from
the list/detail split.

Author: TheGreatAxios

.github/workflows/test.yml

@@ -24,6 +24,9 @@ jobs:
 
     env:
       ARTIFACT_DATABASE_URL: postgres://postgres:postgres@localhost:5457/artifact_core
+      # Package suite TRUNCATEs tables / some migration tests DROP SCHEMA — both
+      # refuse unless opted in against an allowlisted ephemeral database name.
+      ALLOW_DESTRUCTIVE_ARTIFACT_TESTS: "1"
 
     steps:
       - uses: actions/checkout@v4
@@ -38,14 +41,17 @@ jobs:
       - name: check-deps
         run: bun run --cwd packages/artifacts scripts/check-deps.ts
 
+      # typecheck builds first: examples import @corbits/artifacts through the
+      # published dist types, same path a consumer resolves.
       - name: typecheck
         run: bun run typecheck
 
       - name: unit + integration tests
         run: bun run --cwd packages/artifacts test:coverage
 
-      # Emits dist/, which is also what the reference host resolves through —
-      # so this proves the published artifact, not just the sources.
+      # dist/ is already emitted by typecheck; re-run for a clean package build
+      # so acceptance and the node consumer smoke test do not depend on typecheck
+      # having side-effected the tree.
       - name: build
         run: bun run build
 

examples/reference-host/src/index.ts

@@ -34,7 +34,7 @@ import {
   type ResolvedPrincipal,
   type ContentStore,
   type Identity,
-  type SerializedArtifact,
+  type SerializedArtifactBase,
 } from "@corbits/artifacts";
 
 export const DATABASE_URL =
@@ -130,7 +130,7 @@ function createIdentity(db: ArtifactDb): Identity {
 }
 
 /** Display-only decorator. Adds a label, never changes what is returned. */
-async function decorate(_tenantId: string, rows: SerializedArtifact[]) {
+async function decorate(_tenantId: string, rows: readonly SerializedArtifactBase[]) {
   for (const row of rows) {
     (row as Record<string, unknown>).generatedByLabel =
       typeof row.source.generatedBy === "string" ? row.source.generatedBy : null;

package.json

@@ -7,7 +7,7 @@
     "examples/*"
   ],
   "scripts": {
-    "typecheck": "tsc --noEmit",
+    "typecheck": "bun run build && tsc --noEmit",
     "build": "bun run --cwd packages/artifacts build",
     "test": "bun run test:package && bun run test:acceptance",
     "test:package": "bun run --cwd packages/artifacts test",