fix: prevent user ID spoofing by stripping client-supplied 'g' header in withMobileAuth#1927
Open
MehranKhn wants to merge 2 commits into
Open
fix: prevent user ID spoofing by stripping client-supplied 'g' header in withMobileAuth#1927MehranKhn wants to merge 2 commits into
MehranKhn wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
withMobileAuthmiddleware in/src/middleware.tshad two vulnerabilities:Vulnerability 1 — Auth-Key not validated:
The original code only checked if
Auth-Keyheader existed, not its value:Vulnerability 2 — Client-supplied
gheader not stripped:When
Auth-Keymatched, the middleware calledNextResponse.next()without stripping the incoming headers. This meant an attacker could:
Auth-Keyg: {"id": "admin-user-id"}headerAttack looked like this:
Fix
Two things fixed:
Auth-Keyvalue is now validated againstprocess.env.APPX_AUTH_KEYgheader is deleted before forwarding the requestThe JWT path was already safe since it overwrites
gwithnewHeaders.set('g', JSON.stringify(payload))— a server-verified value.Security Impact
Before fix → attacker could access any user's course data by spoofing their ID
After fix →
gheader is always either absent or server-generated, never client-trustedFixes #1924