Doesn't return index of keywords found in text

[issamemariold]

I've noticed that the implementation doesn't return the index of where keywords were found in text. This forces the user to do another search for the keyword to find its index, while the Aho Corasick algorithm should be able to provide this information for no extra cost.

I've made several modifications to the implementation in my fork https://github.com/issamemari/ahocorasick, among which is making the algorithm return the index the index. I'm happy to submit a PR that includes only the changes related to this.

[dbolkensteyn]

Agreed that's a very useful feature to have.

I've just tried out your fork @issamemari , and it was unfortunately on my test data it was 10x slower than this one (330ms vs 30ms). The baseline solution of looping over strings.Index() was at 180ms.

[wangegou]

The query time is too long

[kolkov]

FWIW, coregx/ahocorasick returns match positions (start/end byte offsets) and pattern IDs out of the box via Find, FindAll, and FindAllOverlapping. Zero-allocation IsMatch for existence checks too.