Consider expanding testing for analyze_steady_convergence

[camUrban]

Problem Statement

analyze_steady_convergence()'s level of integration test coverage is unclear.

Location(s): pterasoftware/convergence.py

Proposed Solution

Assess the existing integration test coverage and supplement if necessary.

Additional Context

This issue is referenced by a TEST comment above analyze_steady_convergence().

[IlyasFardaouix]

I think the issue might be that the analyze_steady_convergence function is only being tested with a limited set of input parameters (e.g. num_chordwise_panels=5 and num_spanwise_panels=20) in unsteady_benchmark_converge.py. To better understand the test coverage, I'd like to know if there are any specific edge cases or combinations of parameters that this function is expected to handle.

[camUrban]

Hi @IlyasFardaouix. The comment I left on #148 also applies here (except that the testing module for this function is tests/integration/test_steady_convergence.py.

[IlyasFardaouix]

I think it's great that you're looking into the test coverage for analyze_steady_convergence. To better understand the edge cases, have you considered checking the docstring of analyze_steady_convergence for any notes on expected input ranges or behaviors? That might give us a starting point for identifying potential edge cases to test.