From 73f22cc7f0388a8f6a97ef7f12a6498bf8c36aa1 Mon Sep 17 00:00:00 2001 From: Guru Deshpande <66385690+guru-desh@users.noreply.github.com> Date: Mon, 13 Jul 2026 00:58:52 -0700 Subject: [PATCH] test: unskip pt2e coreml export test as segfault no longer occurs Verified across interpreter and all three CoreML delegates (CPU/BNNS, GPU/MPSGraph, ANE) in both parallel and serial pytest runs that the uint8/per-tensor/asymmetric quantization config no longer segfaults. --- tests/export/test_pt2e_mil_export.py | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/tests/export/test_pt2e_mil_export.py b/tests/export/test_pt2e_mil_export.py index a12b0e61..4fa4b2f4 100644 --- a/tests/export/test_pt2e_mil_export.py +++ b/tests/export/test_pt2e_mil_export.py @@ -79,7 +79,7 @@ for qscheme in QuantizationScheme ] + [ - # uint8 asymmetric per-tensor - crashes with segfault + # uint8 weights with per-tensor granularity, asymmetric qscheme ( torch.uint8, PerTensorGranularity(), @@ -102,22 +102,9 @@ _test_params_with_xfail: list = [] for params in _test_params: dtype, wg, ag, qscheme = params - # uint8 asymmetric per-tensor crashes with segfault - if ( - dtype == torch.uint8 - and isinstance(wg, PerTensorGranularity) - and isinstance(ag, PerTensorGranularity) - and qscheme == QuantizationScheme.ASYMMETRIC - ): - _test_params_with_xfail.append( - pytest.param( - *params, - marks=pytest.mark.skip(reason="Crashes with segfault"), - ), - ) # Per-channel activation with negative axis has SNR below threshold. # TODO: SNR below threshold for per-channel activation with negative axis on CoreML export. - elif isinstance(ag, PerChannelGranularity) and ag.axis is not None and ag.axis < 0: + if isinstance(ag, PerChannelGranularity) and ag.axis is not None and ag.axis < 0: _test_params_with_xfail.append( pytest.param( *params,