Skip to content

Commit 3bdba37

Browse files
barnon-apiiroclaude
andcommitted
Fix long/int type mismatches in tests
Test files still used int for IDs after the library changed them to long. Added casts where the API still expects int parameters. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 8c6667a commit 3bdba37

5 files changed

Lines changed: 21 additions & 21 deletions

File tree

‎test/GitLabApiClient.Test/GroupsClientTest.cs‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ namespace GitLabApiClient.Test
2121
public class GroupsClientTest
2222
{
2323
private readonly List<int> _groupIdsToClean = new List<int>();
24-
private List<int> MilestoneIdsToClean { get; } = new List<int>();
24+
private List<long> MilestoneIdsToClean { get; } = new List<long>();
2525
private List<string> VariableIdsToClean { get; } = new List<string>();
2626

2727
private readonly GroupsClient _sut = new GroupsClient(
@@ -86,7 +86,7 @@ public async Task GroupMilestonesCanBeRetrieved()
8686

8787
//act
8888
var milestones = await _sut.GetMilestonesAsync(TestGroupId);
89-
var milestone = await _sut.GetMilestoneAsync(TestGroupId, createdMilestone.Id);
89+
var milestone = await _sut.GetMilestoneAsync(TestGroupId, (int)createdMilestone.Id);
9090

9191
//assert
9292
milestones.Should().NotBeEmpty();
@@ -207,7 +207,7 @@ public async Task CreatedGroupMilestoneCanBeUpdated()
207207
MilestoneIdsToClean.Add(createdMilestone.Id);
208208

209209
//act
210-
var updatedMilestone = await _sut.UpdateMilestoneAsync(TestGroupTextId, createdMilestone.Id, new UpdateGroupMilestoneRequest()
210+
var updatedMilestone = await _sut.UpdateMilestoneAsync(TestGroupTextId, (int)createdMilestone.Id, new UpdateGroupMilestoneRequest()
211211
{
212212
Title = "milestone22",
213213
StartDate = "2018-11-05",
@@ -237,7 +237,7 @@ public async Task CreatedGroupMilestoneCanBeClosed()
237237
MilestoneIdsToClean.Add(createdMilestone.Id);
238238

239239
//act
240-
var updatedMilestone = await _sut.UpdateMilestoneAsync(TestGroupTextId, createdMilestone.Id, new UpdateGroupMilestoneRequest()
240+
var updatedMilestone = await _sut.UpdateMilestoneAsync(TestGroupTextId, (int)createdMilestone.Id, new UpdateGroupMilestoneRequest()
241241
{
242242
State = UpdatedMilestoneState.Close
243243
});
@@ -353,8 +353,8 @@ public Task DisposeAsync()
353353

354354
private async Task CleanupGroups()
355355
{
356-
foreach (int milestoneId in MilestoneIdsToClean)
357-
await _sut.DeleteMilestoneAsync(TestGroupId, milestoneId);
356+
foreach (long milestoneId in MilestoneIdsToClean)
357+
await _sut.DeleteMilestoneAsync(TestGroupId, (int)milestoneId);
358358

359359
foreach (int groupId in _groupIdsToClean)
360360
await _sut.DeleteAsync(groupId.ToString());

‎test/GitLabApiClient.Test/IssuesClientTest.cs‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public async Task CreatedIssueCanBeUpdated()
3737
});
3838

3939
//act
40-
var updatedIssue = await _sut.UpdateAsync(TestProjectTextId, createdIssue.Iid, new UpdateIssueRequest()
40+
var updatedIssue = await _sut.UpdateAsync(TestProjectTextId, (int)createdIssue.Iid, new UpdateIssueRequest()
4141
{
4242
Assignees = new List<int> { 11 },
4343
Confidential = false,
@@ -63,7 +63,7 @@ public async Task CreatedIssueCanBeClosed()
6363
var createdIssue = await _sut.CreateAsync(TestProjectTextId, new CreateIssueRequest("Title1"));
6464

6565
//act
66-
var updatedIssue = await _sut.UpdateAsync(TestProjectTextId, createdIssue.Iid, new UpdateIssueRequest()
66+
var updatedIssue = await _sut.UpdateAsync(TestProjectTextId, (int)createdIssue.Iid, new UpdateIssueRequest()
6767
{
6868
State = UpdatedIssueState.Close
6969
});
@@ -104,8 +104,8 @@ public async Task CreatedIssueCanBeRetrieved()
104104
});
105105

106106
//act
107-
var issueById = await _sut.GetAsync(TestProjectId, issue.Iid);
108-
var issueByProjectId = (await _sut.GetAllAsync(options: o => o.IssueIds = new[] { issue.Iid })).FirstOrDefault(i => i.Title == title);
107+
var issueById = await _sut.GetAsync(TestProjectId, (int)issue.Iid);
108+
var issueByProjectId = (await _sut.GetAllAsync(options: o => o.IssueIds = new[] { (int)issue.Iid })).FirstOrDefault(i => i.Title == title);
109109
var ownedIssue = (await _sut.GetAllAsync(options: o => o.Scope = Scope.CreatedByMe)).FirstOrDefault(i => i.Title == title);
110110

111111
//assert
@@ -136,7 +136,7 @@ public async Task CreatedIssueNoteCanBeRetrieved()
136136
CreatedAt = DateTime.Now
137137
});
138138
var issueNotes = (await _sut.GetNotesAsync(TestProjectId, issue.Iid)).FirstOrDefault(i => i.Body == body);
139-
var issueNote = await _sut.GetNoteAsync(TestProjectId, issue.Iid, note.Id);
139+
var issueNote = await _sut.GetNoteAsync(TestProjectId, (int)issue.Iid, (int)note.Id);
140140

141141
//assert
142142
note.Should().Match<Note>(n =>
@@ -157,7 +157,7 @@ public async Task CreatedIssueNoteCanBeUpdated()
157157
var createdIssueNote = await _sut.CreateNoteAsync(TestProjectTextId, createdIssue.Iid, new CreateIssueNoteRequest("comment2"));
158158

159159
//act
160-
var updatedIssueNote = await _sut.UpdateNoteAsync(TestProjectTextId, createdIssue.Iid, createdIssueNote.Id, new UpdateIssueNoteRequest("comment22"));
160+
var updatedIssueNote = await _sut.UpdateNoteAsync(TestProjectTextId, (int)createdIssue.Iid, (int)createdIssueNote.Id, new UpdateIssueNoteRequest("comment22"));
161161

162162
//assert
163163
updatedIssueNote.Should().Match<Note>(n =>

‎test/GitLabApiClient.Test/MergeRequestClientTest.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ public async Task MergeRequestWithoutCommitsCannotBeAccepted()
9696
});
9797

9898
Func<Task<MergeRequest>> acceptAction = () =>
99-
_sut.AcceptAsync(GitLabApiHelper.TestProjectTextId, createdMergeRequest.Iid, new AcceptMergeRequest());
99+
_sut.AcceptAsync(GitLabApiHelper.TestProjectTextId, (int)createdMergeRequest.Iid, new AcceptMergeRequest());
100100

101101
acceptAction.Should().Throw<GitLabException>().
102102
WithMessage("{\"message\":\"405 Method Not Allowed\"}").
@@ -124,7 +124,7 @@ private async Task DeleteAllMergeRequests()
124124
{
125125
var mergeRequests = await _sut.GetAsync(GitLabApiHelper.TestProjectId);
126126
await Task.WhenAll(mergeRequests.Select(
127-
m => _sut.DeleteAsync(GitLabApiHelper.TestProjectId, m.Iid)));
127+
m => _sut.DeleteAsync(GitLabApiHelper.TestProjectId, (int)m.Iid)));
128128
}
129129
}
130130
}

‎test/GitLabApiClient.Test/ProjectsClientTest.cs‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ namespace GitLabApiClient.Test
2222
public class ProjectsClientTest : IAsyncLifetime
2323
{
2424
private List<int> ProjectIdsToClean { get; } = new List<int>();
25-
private List<int> MilestoneIdsToClean { get; } = new List<int>();
25+
private List<long> MilestoneIdsToClean { get; } = new List<long>();
2626
private List<string> VariableIdsToClean { get; } = new List<string>();
2727

2828
private readonly ProjectsClient _sut = new ProjectsClient(
@@ -76,7 +76,7 @@ public async Task ProjectMilestonesRetrieved()
7676

7777
//act
7878
var milestones = await _sut.GetMilestonesAsync(GitLabApiHelper.TestProjectId);
79-
var milestone = await _sut.GetMilestoneAsync(GitLabApiHelper.TestProjectId, createdMilestone.Id);
79+
var milestone = await _sut.GetMilestoneAsync(GitLabApiHelper.TestProjectId, (int)createdMilestone.Id);
8080

8181
//assert
8282
milestones.Should().NotBeEmpty();
@@ -286,7 +286,7 @@ public async Task CreatedProjectMilestoneCanBeUpdated()
286286
MilestoneIdsToClean.Add(createdMilestone.Id);
287287

288288
//act
289-
var updatedMilestone = await _sut.UpdateMilestoneAsync(GitLabApiHelper.TestProjectTextId, createdMilestone.Id, new UpdateProjectMilestoneRequest()
289+
var updatedMilestone = await _sut.UpdateMilestoneAsync(GitLabApiHelper.TestProjectTextId, (int)createdMilestone.Id, new UpdateProjectMilestoneRequest()
290290
{
291291
Title = "milestone23",
292292
StartDate = "2018-11-05",
@@ -353,7 +353,7 @@ public async Task CreatedProjectMilestoneCanBeClosed()
353353
MilestoneIdsToClean.Add(createdMilestone.Id);
354354

355355
//act
356-
var updatedMilestone = await _sut.UpdateMilestoneAsync(GitLabApiHelper.TestProjectTextId, createdMilestone.Id, new UpdateProjectMilestoneRequest()
356+
var updatedMilestone = await _sut.UpdateMilestoneAsync(GitLabApiHelper.TestProjectTextId, (int)createdMilestone.Id, new UpdateProjectMilestoneRequest()
357357
{
358358
State = UpdatedMilestoneState.Close
359359
});
@@ -411,8 +411,8 @@ public async Task ExportImportProject()
411411
private async Task CleanupProjects()
412412
{
413413

414-
foreach (int milestoneId in MilestoneIdsToClean)
415-
await _sut.DeleteMilestoneAsync(GitLabApiHelper.TestProjectId, milestoneId);
414+
foreach (long milestoneId in MilestoneIdsToClean)
415+
await _sut.DeleteMilestoneAsync(GitLabApiHelper.TestProjectId, (int)milestoneId);
416416

417417
foreach (int projectId in ProjectIdsToClean)
418418
await _sut.DeleteAsync(projectId);

‎test/GitLabApiClient.Test/ToDoListClientTest.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ private async Task DeleteAllMergeRequests()
140140
{
141141
var mergeRequests = await mergeRequestsClient.GetAsync(GitLabApiHelper.TestProjectId);
142142
await Task.WhenAll(mergeRequests.Select(
143-
m => mergeRequestsClient.DeleteAsync(GitLabApiHelper.TestProjectId, m.Iid)));
143+
m => mergeRequestsClient.DeleteAsync(GitLabApiHelper.TestProjectId, (int)m.Iid)));
144144
}
145145
}
146146
}

0 commit comments

Comments
 (0)