elasticsearch5 'actionGet' method can not be intercepted

[larrying]

I faced a problem that elasticsearch5 'actionGet' method can not be intercepted, if i change it to 'get' method, it works. Is it bug?

[wu-sheng]

I don't understand what do you mean can? Is that a real method in the current class? abstract methods can't be intercepted, unless you use HierarchyMatch for the parent class.

[larrying]

thank you for reminding me. I have deleted it

Is it bug ？

[wu-sheng]

Then, the error is quite clear. The PlainListenableActionFutureInterceptor doesn't fit the target method invocation.

[wu-sheng]

More specifically, this is this line from your stack, https://github.com/apache/skywalking-java/blob/a7a4faabb158ea8322170e3c7cae0210a8c4e7b4/apm-sniffer/apm-sdk-plugin/elasticsearch-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/elasticsearch/v5/PlainListenableActionFutureInterceptor.java#L56.

The interceptor can't do response.getHits().getTotalHits() from JVM error report. I think this must be caused by different method parameter and return value(SearchResponse response = (SearchResponse) ret).

[larrying]

if i want to resolve this problem, enhance the PlainListenableActionFutureInterceptor?

[wu-sheng]

I don't know who wrote this plugin, I just explain what you asked about. SkyWalking's plugins are contributed by hundreds of people.
You actually should basically understand how plugin works, then try to enhance. But enhancement doesn't have to relate to this interceptor. One plugin has multiple interceptors for different cases.