refactor: moved ErrInternal to the chain-sdk

Author: vertex451

CHANGELOG.md

@@ -48,4 +48,4 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 * Fix bug in ditribution and querying rewards
 
-* Replaced sdkerrors.Register with sdkerrors.RegisterWithGRPCCode for the proper error propagation
+* Moved x/provider/handler.ErrInternal to the chain-sdk/go/node/provider/v1beta4 package.

x/provider/handler/handler_test.go

@@ -253,8 +253,8 @@ func TestProviderDeleteExisting(t *testing.T) {
 
 	res, err := suite.handler(suite.ctx, deleteMsg)
 	require.Nil(t, res)
-	require.EqualError(t, err, "NOTIMPLEMENTED: "+handler.ErrInternal.Error())
-	require.True(t, errors.Is(err, handler.ErrInternal))
+	require.EqualError(t, err, "NOTIMPLEMENTED: "+types.ErrInternal.Error())
+	require.True(t, errors.Is(err, types.ErrInternal))
 
 	t.Run("ensure event created", func(_ *testing.T) {
 		// TODO: this should emit a ProviderDelete

x/provider/handler/server.go

@@ -4,7 +4,6 @@ import (
 	"context"
 
 	sdkerrors "cosmossdk.io/errors"
-	"google.golang.org/grpc/codes"
 
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	types "pkg.akt.dev/go/node/provider/v1beta4"
@@ -13,11 +12,6 @@ import (
 	"pkg.akt.dev/node/x/provider/keeper"
 )
 
-var (
-	// ErrInternal defines registered error code for internal error
-	ErrInternal = sdkerrors.RegisterWithGRPCCode(types.ModuleName, 10, codes.Internal, "internal error")
-)
-
 type msgServer struct {
 	provider keeper.IKeeper
 	market   mkeeper.IKeeper
@@ -45,7 +39,7 @@ func (ms msgServer) CreateProvider(goCtx context.Context, msg *types.MsgCreatePr
 	}
 
 	if err := ms.provider.Create(ctx, types.Provider(*msg)); err != nil {
-		return nil, ErrInternal.Wrapf("err: %v", err)
+		return nil, types.ErrInternal.Wrapf("err: %v", err)
 	}
 
 	return &types.MsgCreateProviderResponse{}, nil
@@ -66,7 +60,7 @@ func (ms msgServer) UpdateProvider(goCtx context.Context, msg *types.MsgUpdatePr
 	}
 
 	if err := ms.provider.Update(ctx, types.Provider(*msg)); err != nil {
-		return nil, sdkerrors.Wrapf(ErrInternal, "err: %v", err)
+		return nil, sdkerrors.Wrapf(types.ErrInternal, "err: %v", err)
 	}
 
 	return &types.MsgUpdateProviderResponse{}, nil
@@ -85,5 +79,5 @@ func (ms msgServer) DeleteProvider(goCtx context.Context, msg *types.MsgDeletePr
 	}
 
 	// TODO: cancel leases
-	return nil, ErrInternal.Wrap("NOTIMPLEMENTED")
+	return nil, types.ErrInternal.Wrap("NOTIMPLEMENTED")
 }