[dictionary] Statut de la description "Vide" does not return any results

[driusan]

In the dictionary module on the 29 branch, filtering for "Vide" with the user's language set to French returns no results on raisinbread while English, Hindi, Chinese, and Japanese all return 27 rows as a result.

Filtering for "Modifié" or "Inchangé" in French works correctly. It's only the "Vide" option that does not work.

[lapadulamichael]

The reason for this is that part of the heading of the French po file seems to leak into the description when French is enabled which is why Vide does not return it as empty.

Japanese :

French :

This only happens on the testing environment as I was unable to reproduce this is my dev environment. Vide and French work correctly while on the 29 branch.

In my dev environment :

[driusan]

@lapadulamichael This was on my testing environment. When you see headers leaking like that it's because (d)gettext has an (imo stupid) behaviour where gettext on the empty string returns the headers. It's the documented behaviour of the function and we need to check / handle the empty string explicitly whenever it's called to avoid the header leakage.

But if that was the reason wouldn't it also be case for other languages?

[lapadulamichael]

@driusan
For some reason it is not the case for the other languages. It's hard to test more in detail since I am not able to reproduce it in my dev VM.