Skip to content

Commit 7203696

Browse files
committed
format and changelog
1 parent 3c379fe commit 7203696

3 files changed

Lines changed: 18 additions & 5 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,15 @@
1+
## 0.1.14
2+
3+
- #66 Detect readiness of the server and output ready message
4+
5+
## 0.1.13
6+
7+
- # 50 Bump Workiva/gha-dart-oss from 0.1.5 to 0.1.7 in the gha group across 1 directory
8+
9+
- #51 Raise the meta dependency min to v1.16.0
10+
11+
- #52 raise_min_dart_sdk_2_19
12+
113
## 0.1.12
214

315
- Update ranges of dependencies so that in Dart 3 we can resolve to analyzer 6, while still working with Dart 2.19. https://github.com/Workiva/webdev_proxy/pull/46

‎lib/src/serve_command.dart‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,6 @@ class ServeCommand extends Command<int> {
214214
}
215215
// to reduce exception noise, wait a few seconds
216216
await Future.delayed(const Duration(seconds: 3));
217-
218217
await Future.any([
219218
Future.wait(readyByDir.values.map((completer) => completer.future)),
220219
exitCodeCompleter.future,
@@ -240,16 +239,19 @@ class ServeCommand extends Command<int> {
240239
while (true) {
241240
final uri = Uri.parse('http://$host:$port');
242241
try {
243-
stdout.writeln('[INFO] Pinging server $uri to detect responsiveness...an exception from the server means it is not ready.');
242+
stdout.writeln(
243+
'[INFO] Pinging server $uri to detect responsiveness...an exception from the server means it is not ready.');
244244
final response = await http.get(uri);
245245
if (response.statusCode == 200) {
246246
stdout.writeln('[INFO] $uri responded with 200, server is ready!');
247247
return;
248248
}
249-
stdout.writeln('[INFO] $uri responded with ${response.statusCode}, server is not ready yet.');
249+
stdout.writeln(
250+
'[INFO] $uri responded with ${response.statusCode}, server is not ready yet.');
250251
} catch (_) {
251252
// Keep polling until webdev starts listening and serving successfully.
252-
stdout.writeln('[INFO] $uri responded with an error, server is not ready yet.');
253+
stdout.writeln(
254+
'[INFO] $uri responded with an error, server is not ready yet.');
253255
}
254256
await Future.delayed(pollInterval);
255257
}

‎lib/src/webdev_server.dart‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ class WebdevServer {
5757
mode: mode,
5858
);
5959

60-
6160
// `inheritStdio` and `detached` do not expose readable stdout streams.
6261
// if (mode == ProcessStartMode.normal ||
6362
// mode == ProcessStartMode.detachedWithStdio) {

0 commit comments

Comments
 (0)