PHPStan: Retire booleanAnd.alwaysFalse baseline

- In src/wp-admin/themes.php, line 128 statically sets $parent_file = 'themes.php'. Therefore, empty( $parent_file ) is always false. Simplify the current menu item check to $item[2] === $parent_file.
- In src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php, $schema was used in update_item() without being assigned, causing $schema['properties']['featured_media'] to always evaluate to empty/false and generating an undefined variable notice. Initialize $schema = $this->get_item_schema(); as done in create_item().
- Regenerate PHPStan baselines to delete tests/phpstan/baselines/booleanAnd.alwaysFalse.neon and update phpstan.neon.dist.

Author: huzaifaalmesbah

phpstan.neon.dist

@@ -27,7 +27,6 @@ includes:
 	- tests/phpstan/baselines/arrayValues.list.neon
 	- tests/phpstan/baselines/assign.propertyType.neon
 	- tests/phpstan/baselines/binaryOp.invalid.neon
-	- tests/phpstan/baselines/booleanAnd.alwaysFalse.neon
 	- tests/phpstan/baselines/booleanAnd.leftAlwaysTrue.neon
 	- tests/phpstan/baselines/booleanAnd.rightAlwaysTrue.neon
 	- tests/phpstan/baselines/booleanNot.alwaysFalse.neon

src/wp-admin/themes.php

@@ -373,9 +373,7 @@
 		}
 
 		// 0 = name, 1 = capability, 2 = file.
-		if ( 0 === strcmp( $self, $item[2] ) && empty( $parent_file )
-			|| $parent_file && $item[2] === $parent_file
-		) {
+		if ( $item[2] === $parent_file ) {
 			$class = ' current';
 		}
 

src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php

@@ -991,6 +991,7 @@ public function update_item( $request ) {
 			update_post_meta( $data['id'], '_wp_attachment_image_alt', $request['alt_text'] );
 		}
 
+		$schema     = $this->get_item_schema();
 		$attachment = get_post( $request['id'] );
 
 		if ( ! empty( $schema['properties']['featured_media'] ) && isset( $request['featured_media'] ) ) {

tests/phpstan/baselines/booleanAnd.alwaysFalse.neon

@@ -23,11 +23,6 @@ parameters:
 			identifier: booleanAnd.leftAlwaysTrue
 			count: 1
 			path: ../../../src/wp-admin/network/users.php
-		-
-			message: '#^Left side of && is always true\.$#'
-			identifier: booleanAnd.leftAlwaysTrue
-			count: 1
-			path: ../../../src/wp-admin/themes.php
 		-
 			message: '#^Left side of && is always true\.$#'
 			identifier: booleanAnd.leftAlwaysTrue

tests/phpstan/baselines/booleanAnd.leftAlwaysTrue.neon

@@ -23,11 +23,6 @@ parameters:
 			identifier: empty.variable
 			count: 1
 			path: ../../../src/wp-admin/includes/class-wp-posts-list-table.php
-		-
-			message: '#^Variable \$parent_file in empty\(\) always exists and is not falsy\.$#'
-			identifier: empty.variable
-			count: 1
-			path: ../../../src/wp-admin/themes.php
 		-
 			message: '#^Variable \$addl_path in empty\(\) always exists and is always falsy\.$#'
 			identifier: empty.variable
@@ -43,11 +38,6 @@ parameters:
 			identifier: empty.variable
 			count: 1
 			path: ../../../src/wp-includes/class-wp-query.php
-		-
-			message: '#^Variable \$schema in empty\(\) is never defined\.$#'
-			identifier: empty.variable
-			count: 1
-			path: ../../../src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php
 		-
 			message: '#^Variable \$the_parent in empty\(\) always exists and is not falsy\.$#'
 			identifier: empty.variable

tests/phpstan/baselines/empty.variable.neon

@@ -458,11 +458,6 @@ parameters:
 			identifier: variable.undefined
 			count: 1
 			path: ../../../src/wp-admin/theme-install.php
-		-
-			message: '#^Variable \$self might not be defined\.$#'
-			identifier: variable.undefined
-			count: 1
-			path: ../../../src/wp-admin/themes.php
 		-
 			message: '#^Variable \$submenu might not be defined\.$#'
 			identifier: variable.undefined