Tests: Make admin test data providers static.

Declare the data providers in `tests/phpunit/tests/admin/` as `public static` for compatibility with newer PHPUnit versions. Preserve their datasets and assertions. Update direct calls to the submenu provider to use `self::`.

Developed in: #14389

Props rejaulalomkhan.
See #66211.


git-svn-id: https://develop.svn.wordpress.org/trunk@64441 602fd350-edb4-49c9-b593-d223f7449a82

Author: lancewillett

tests/phpunit/tests/admin/exportWp.php

@@ -136,7 +136,7 @@ public function test_should_include_attachments( array $args, array $expected )
 	 *
 	 * @return array
 	 */
-	public function data_should_include_attachments() {
+	public static function data_should_include_attachments() {
 		return array(
 			'for all content'           => array(
 				'args'     => array(

tests/phpunit/tests/admin/includes/comment/EditComment_Test.php

@@ -415,7 +415,7 @@ public function test_should_reject_spam_or_trashed_parent( $comment_approved ) {
 	 *
 	 * @return array[]
 	 */
-	public function data_should_reject_spam_or_trashed_parent() {
+	public static function data_should_reject_spam_or_trashed_parent() {
 		return array(
 			'a spam parent'    => array( 'spam' ),
 			'a trashed parent' => array( 'trash' ),

tests/phpunit/tests/admin/includes/misc/CustomizerMobileViewportMeta_Test.php

@@ -29,7 +29,7 @@ public function test_customizer_mobile_viewport_meta( $viewport_meta, $expected
 	 *     expected:      string,
 	 * }>
 	 */
-	public function data_customizer_mobile_viewport_meta(): array {
+	public static function data_customizer_mobile_viewport_meta(): array {
 		return array(
 			'default'                       => array(
 				'viewport_meta' => 'width=device-width,initial-scale=1.0',

tests/phpunit/tests/admin/includes/misc/WpAdminCanonicalUrl_Test.php

@@ -57,7 +57,7 @@ public function test_wp_admin_canonical_url( array $server_vars, $expected ) {
 	 *     expected:    string
 	 * }>
 	 */
-	public function data_wp_admin_canonical_url(): array {
+	public static function data_wp_admin_canonical_url(): array {
 		return array(
 			'no removable query args'       => array(
 				'server_vars' => array(

tests/phpunit/tests/admin/includes/misc/WpAdminViewportMeta_Test.php

@@ -39,7 +39,7 @@ function () use ( $filter_value ) {
 	 *     expected:     string,
 	 * }>
 	 */
-	public function data_wp_admin_viewport_meta(): array {
+	public static function data_wp_admin_viewport_meta(): array {
 		return array(
 			'default value'          => array(
 				'filter_value' => null,

tests/phpunit/tests/admin/includes/misc/WpDocLinkParse_Test.php

@@ -28,7 +28,7 @@ public function test_wp_doc_link_parse( $content, $expected ) {
 	 *     expected: string[],
 	 * }>
 	 */
-	public function data_wp_doc_link_parse(): array {
+	public static function data_wp_doc_link_parse(): array {
 		return array(
 			'empty string'              => array(
 				'content'  => '',

tests/phpunit/tests/admin/includes/misc/WpHeartbeatSetSuspension_Test.php

@@ -59,7 +59,7 @@ public function test_wp_heartbeat_set_suspension( $pagenow_value, $expected ) {
 	 *     expected:      string,
 	 * }>
 	 */
-	public function data_wp_heartbeat_set_suspension(): array {
+	public static function data_wp_heartbeat_set_suspension(): array {
 		return array(
 			'post.php'     => array(
 				'pagenow_value' => 'post.php',

tests/phpunit/tests/admin/includes/misc/WpMakeThemeFileTree_Test.php

@@ -28,7 +28,7 @@ public function test_wp_make_theme_file_tree( $allowed_files, $expected ) {
 	 *     expected:      array<string, string|array>,
 	 * }>
 	 */
-	public function data_wp_make_theme_file_tree(): array {
+	public static function data_wp_make_theme_file_tree(): array {
 		return array(
 			'empty list'         => array(
 				'allowed_files' => array(),

tests/phpunit/tests/admin/includes/misc/WpPrivacySettingsFilterDraftPageTitles_Test.php

@@ -40,7 +40,7 @@ public function test_wp_privacy_settings_filter_draft_page_titles( $expected, $t
 	 *     screen_id:   string,
 	 * }>
 	 */
-	public function data_wp_privacy_settings_filter_draft_page_titles(): array {
+	public static function data_wp_privacy_settings_filter_draft_page_titles(): array {
 		return array(
 			'draft page on privacy screen'     => array(
 				'expected'    => 'Privacy Policy (Draft)',

tests/phpunit/tests/admin/includes/plugin-install/WpGetPluginActionButton_Test.php

@@ -123,7 +123,7 @@ public function test_should_not_return_empty_string_with_proper_capabilities_sin
 	 *
 	 * @return array[]
 	 */
-	public function data_capabilities() {
+	public static function data_capabilities() {
 		return self::text_array_to_dataprovider( array( 'install_plugins', 'update_plugins' ) );
 	}