Tests: Make date test data providers static.

Declare the data providers in `tests/phpunit/tests/date/` as `public static` for compatibility with newer PHPUnit versions. Preserve their datasets and assertions.

Developed in: #14397

Props rejaulalomkhan.
See #66211.


git-svn-id: https://develop.svn.wordpress.org/trunk@64447 602fd350-edb4-49c9-b593-d223f7449a82

Author: lancewillett

tests/phpunit/tests/date/currentTime.php

@@ -145,7 +145,7 @@ public function test_should_return_correct_local_time( $timezone ) {
 	 *
 	 * @return array[]
 	 */
-	public function data_timezones() {
+	public static function data_timezones() {
 		return array(
 			array( 'Europe/Helsinki' ),
 			array( 'Indian/Antananarivo' ),
@@ -255,7 +255,7 @@ public function test_partial_hour_timezones_match_datetime_offset( $partial_hour
 	 *
 	 * @return array[]
 	 */
-	public function data_partial_hour_timezones_with_timestamp() {
+	public static function data_partial_hour_timezones_with_timestamp() {
 		return array(
 			'+12:45' => array( 12.75, 'Pacific/Chatham' ), // New Zealand, Chatham Islands.
 			'+9:30'  => array( 9.5, 'Australia/Darwin' ), // Australian Northern Territory.

tests/phpunit/tests/date/dateI18n.php

@@ -151,7 +151,7 @@ public function test_date_i18n_handles_shorthand_formats( $short, $full ) {
 		$this->assertSame( $short, date_i18n( '\\' . $short ) );
 	}
 
-	public function data_formats() {
+	public static function data_formats() {
 		return array(
 			array(
 				'c',
@@ -216,7 +216,7 @@ public function test_should_handle_dst( $time, $timezone ) {
 		$this->assertSame( $datetime->format( $format ), date_i18n( $format, $wp_timestamp ) );
 	}
 
-	public function data_should_handle_dst() {
+	public static function data_should_handle_dst() {
 		return array(
 			'Before DST start' => array( '2019-03-31 02:59:00', 'Europe/Helsinki' ),
 			'After DST start'  => array( '2019-03-31 04:01:00', 'Europe/Helsinki' ),

tests/phpunit/tests/date/getFeedBuildDate.php

@@ -178,7 +178,7 @@ public function test_should_return_correct_build_date_for_cold_query_fields( str
 	 *
 	 * @return array<non-falsy-string, array{ non-falsy-string }>
 	 */
-	public function data_cold_post_query_fields(): array {
+	public static function data_cold_post_query_fields(): array {
 		return array(
 			'IDs'     => array( 'ids' ),
 			'partial' => array( 'id=>parent' ),

tests/phpunit/tests/date/maybeDeclineDate.php

@@ -71,7 +71,7 @@ public function filter__enable_months_names_declension( $translation, $text, $co
 		return $translation;
 	}
 
-	public function data_wp_maybe_decline_date() {
+	public static function data_wp_maybe_decline_date() {
 		return array(
 			array( 'ru_RU', 'j F', '21 Июнь', '21 июня' ),
 			array( 'ru_RU', 'j F Y', '1 Январь 2016', '1 января 2016' ),

tests/phpunit/tests/date/query.php

@@ -548,7 +548,7 @@ public function test_build_mysql_datetime( $datetime, $expected, $default_to_max
 		$this->assertEqualsWithDelta( strtotime( $expected ), strtotime( $found ), 10, $message );
 	}
 
-	public function data_build_mysql_datetime() {
+	public static function data_build_mysql_datetime() {
 		return array(
 			array( '2019-06-04T08:18:24+03:00', '2019-06-04 05:18:24' ),
 			array( '2019-06-04T05:18:24+00:00', '2019-06-04 05:18:24' ),
@@ -583,7 +583,7 @@ public function test_build_mysql_datetime_with_custom_timezone( $datetime, $expe
 		$this->assertEqualsWithDelta( strtotime( $expected ), strtotime( $found ), 10, $message );
 	}
 
-	public function data_build_mysql_datetime_with_custom_timezone() {
+	public static function data_build_mysql_datetime_with_custom_timezone() {
 		return array(
 			array( '2019-06-04T08:18:24+03:00', '2019-06-04 08:18:24' ),
 			array( '2019-06-04T05:18:24+00:00', '2019-06-04 08:18:24' ),

tests/phpunit/tests/date/wpCheckdate.php

@@ -31,7 +31,7 @@ public function test_wp_checkdate( $month, $day, $year, $source_date, $expected
 	 *
 	 * @return array
 	 */
-	public function data_wp_checkdate() {
+	public static function data_wp_checkdate() {
 		return array(
 			'integers'              => array( 1, 1, 1, '1-1-1', true ),
 			'strings'               => array( '1', '1', '1', '1-1-1', true ),

tests/phpunit/tests/date/wpDate.php

@@ -106,7 +106,7 @@ public function test_should_format_date( $expected, $format ) {
 	 *
 	 * @return array
 	 */
-	public function data_should_format_date() {
+	public static function data_should_format_date() {
 		return array(
 			'Swatch Internet Time'                        => array(
 				'expected' => '041',

tests/phpunit/tests/date/wpTimezone.php

@@ -44,7 +44,7 @@ public function test_should_convert_gmt_offset( $gmt_offset, $tz_name ) {
 	 *
 	 * @return array
 	 */
-	public function data_should_convert_gmt_offset() {
+	public static function data_should_convert_gmt_offset() {
 		return array(
 			array( -12, '-12:00' ),
 			array( -11.5, '-11:30' ),