Better global namespace removal, plus a diff helper

Author: dmsnell

lib/runner.php

@@ -135,25 +135,30 @@ function parse_files( $files, $root ) {
 		throw $e;
 	}
 
-	/*
-	 * nikic/php-parser in version 3 started adding a namespace prefix
-	 * at the start of global names, but this is different than how the
-	 * documentation was previously generated. this removes those prefixes.
-	 */
-	array_walk_recursive(
-		$output,
-		static function ( &$value ) {
-			if ( ! is_string( $value ) || strlen( $value ) < 2 || '\\' !== $value[0] ) {
-				return;
-			}
+	if ( true ) {
+		/*
+		 * nikic/php-parser in version 3 started adding a namespace prefix
+		 * at the start of global names, but this is different than how the
+		 * documentation was previously generated. this removes those prefixes.
+		 */
+		array_walk_recursive(
+			$output,
+			static function( &$value ) {
+				if ( is_string( $value ) ) {
+					// "\wp_kses()" -> "wp_kses()"
+					$without_global_namespace = preg_replace(
+						'~(^|\p{Z})\\\\([A-Z_a-z\x80-\xFF][0-9A-Z_a-z\x80-\xFF]*)(\p{Z}|$)~',
+						'$1$2$3',
+						$value,
+					);
 
-			// "\wp_kses()" -> "wp_kses()"
-			$next_slash = strpos( $value, '\\', 1 );
-			if ( false === $next_slash ) {
-				$value = substr( $value, 1 );
+					if ( $value !== $without_global_namespace ) {
+						$value = $without_global_namespace;
+					}
+				}
 			}
-		}
-	);
+		);
+	}
 
 	return $output;
 }

prep-diff.php

@@ -0,0 +1,28 @@
+<?php
+
+$output = json_decode( file_get_contents( 'php://stdin' ), true );
+
+array_walk_recursive(
+	$output,
+	static function( &$value, $key ) {
+		if ( 'line' === $key || 'end_line' === $key ) {
+			$value = 0;
+			return;
+		}
+
+		if ( is_string( $value ) ) {
+			// "\wp_kses()" -> "wp_kses()"
+			$without_global_namespace = preg_replace(
+				'~(^|\p{Z})\\\\([A-Z_a-z\x80-\xFF][0-9A-Z_a-z\x80-\xFF]*)(\p{Z}|$)~',
+				'$1$2$3',
+				$value,
+			);
+
+			if ( $value !== $without_global_namespace ) {
+				$value = $without_global_namespace;
+			}
+		}
+	}
+);
+
+echo json_encode( $output, JSON_PRETTY_PRINT );