Job.to_dict fails if GID can't be resolved

[mrvn]

Some groups where removed from LDAP by accident so their name can no longer be resolved. This causes pyslurm to crash:

  File "pyslurm/xcollections.pyx", line 460, in pyslurm.xcollections.MultiClusterMap.to_dict
  File "pyslurm/xcollections.pyx", line 620, in pyslurm.xcollections.multi_dict_recursive
  File "pyslurm/xcollections.pyx", line 609, in pyslurm.xcollections.dict_recursive
  File "pyslurm/core/job/job.pyx", line 341, in pyslurm.core.job.job.Job.to_dict
  File "pyslurm/utils/helpers.pyx", line 335, in pyslurm.utils.helpers.instance_to_dict
  File "pyslurm/core/job/job.pyx", line 706, in pyslurm.core.job.job.Job.group_name.__get__
  File "pyslurm/utils/helpers.pyx", line 69, in pyslurm.utils.helpers.gid_to_name
  File "pyslurm/utils/helpers.pyx", line 87, in pyslurm.utils.helpers.gid_to_name
  File "pyslurm/utils/helpers.pyx", line 83, in pyslurm.utils.helpers.gid_to_name
KeyError: 'getgrgid(): gid not found: 2002'

This should fall back to reporting the numerical value of the group.

[giovtorres]

I believe this was already addressed and the fix is in the main branch . Which version of PySlurm are you running? Assuming a version before #391, where the fix was applied, you could backport the fix here:

diff --git a/pyslurm/utils/helpers.pyx b/pyslurm/utils/helpers.pyx
--- a/pyslurm/utils/helpers.pyx
+++ b/pyslurm/utils/helpers.pyx
@@ -43,7 +43,7 @@ MEMORY_UNITS = {
 }


-cpdef uid_to_name(uint32_t uid, err_on_invalid=True, dict lookup={}):
+cpdef uid_to_name(uint32_t uid, err_on_invalid=False, dict lookup={}):
     """Translate UID to a User-Name."""
     if uid == slurm.NO_VAL or uid == slurm.INFINITE:
         return None
@@ -63,10 +63,10 @@ cpdef uid_to_name(uint32_t uid, err_on_invalid=True, dict lookup={}):
             if err_on_invalid:
                 raise e

-    return None
+    return str(uid)


-cpdef gid_to_name(uint32_t gid, err_on_invalid=True, dict lookup={}):
+cpdef gid_to_name(uint32_t gid, err_on_invalid=False, dict lookup={}):
     """Translate a uid to a Group-Name."""
     if gid == slurm.NO_VAL or gid == slurm.INFINITE:
         return None
@@ -86,7 +86,7 @@ cpdef gid_to_name(uint32_t gid, err_on_invalid=True, dict lookup={}):
             if err_on_invalid:
                 raise e

-    return None
+    return str(gid)


 def user_to_uid(user, err_on_invalid=True):

Let me know if that helps. Thanks.