Various non-core modules not working in version 6

[tkolakow]

Please note that these are attempts to get non-converted modules from version 5 working in Phorum version 6.0.3 and 6.0.4, so I do understand that the issue may be due to the code in the module needing to be upgraded to support PHP 8.3.

I've been working (if you want to call it that) with AI in attempt to get the below modules running in version 6.0.x of Phorum. I'm starting to notice a pattern possibly related to custom profile fields, so maybe this is indeed an issue with the Phorum 6 core?

The modules and the versions I'm working with are as follows -

1. Ignore User - no version number
2. Terms Of Service - version: 2.4.2
3. User Polls - version: 1.0.15
4. User Avatars - version: 3.0.4

Any help here would be greatly appreciated.

[brianlmoon]

What issue are you running into with custom profile fields?

[brianlmoon]

Also, what version of Phorum 5 were you running?

[tkolakow]

Also, what version of Phorum 5 were you running?

Our current version of Phorum 5 shouldn't impact anything here since this is happening on fresh testing installs of both 6.0.3 and 6.0.4.

We are using version 5.2.18 on our live site that we'll hopefully be upgrading to 6.0.x once we get everything we need working (both the core and required modules) on the latest and greatest version. The ultimate goal would then be to go to version 10 once it's ready for primetime (earliest we would be able to make that jump would be 1Q 2027, which may work with your development schedule).

[tkolakow]

What issue are you running into with custom profile fields?

The two modules I spent hours on were the TOS and the Polls. From what I can remember -

• The TOS was a simple issue with the acceptance date. The module was not able to create the custom profile field to store it. Once I did it manually via the admin interface, it wasn't able to read it so I was constantly getting prompted to accept the TOS. I eventually was able to get it to read it, but then updating it was the final issue that I somehow got fixed thanks to crappy AI advice that went down all kinds of rabbit holes. I honestly do not remember what the fix was since so much trial and error was done here.
• The Poll module was something similar, where it would not add the value to the user. The module would ultimately install if I'm remembering correctly, and would allow you to create polls and vote..... as many times as you wanted. I am the only user on the forum and during testing, I voted on the same poll 72 times before giving up on trying to fix it. ;-) I do remember that AI was complaining about how the data array assigned to users for the poll tracking was not returning an array, but a string instead (or was it vice versa). It was having me recreate and cast variables, and was wanting me to make changes outside of the module files (I made it a point to not accept any recommendations to change core Phorum objects). I never got this working 100% and gave up.

Hopefully that helps, and thanks for the quick responses. Feel free to ask any additional questions and I'll do my best to answer them. We are HUGE fans of the threaded version of Phorum and were about to move to a new, linear solution but the testing was interrupted with your release of version 6, and throwing us a lifeline by doing so. We appreciate your efforts!

[brianlmoon]

User Avatars worked fine for me with 6.0.4. I am still working on finding the others in the Modules forum.

[brianlmoon]

Topic Polls has been updated. It will require a new release of Phorum 6 too though.

[brianlmoon]

New version of Phorum 6.0.6 released.

I can't find the other two modules in the modules forum.

[tkolakow]

New version of Phorum 6.0.6 released.

I can't find the other two modules in the modules forum.

TOS - https://www.phorum.org/support/read.php?62,129366

Ignore User - hmmm.... it doesn't seem to exist anymore? WAIT! I may have missed the part regarding having to create the dang Custom Profile field manually, so this may be my fault. Let me test and I'll confirm this.

UPDATE - I manually created the custom profile field and confirmed that the edits exist in the read.tpl file, and now this module is causing 500 errors, so there's more to it than just the need to make those changes.

Let me post the code for it here - it only has 3 files -

Readme.txt -
Ignore user module - installation instructions

1. Copy the "ignore" directory into the Phorum mods directory

2. IMPORTANT STEP:
   Phorum Admin -> Custom Profiles -> add a profile field called mod_ignore

3. Phorum Admin -> Modules -> Turn on the ignore user mod

4. Make two changes to your read.tpl template file:

   a) Add the following at the top of the file:

   {IF MOD_IGNORE_JAVASCRIPT}{MOD_IGNORE_JAVASCRIPT}{/IF}

   b) Before the at the end of the "Postedby" line, insert:

   {IF MESSAGES->mod_ignore_url} [{MESSAGES->mod_ignore_text}]{/IF}

For problems or questions, please post on the "Ignore user module" thread at
http://phorum.org/phorum5/list.php?16

===========info.txt================= -
hook: lang|
hook: read|mod_ignore_read
hook: format|mod_ignore_format
title: Ignore user mod
desc: This module allows a user to ignore messages posted by other users

category: user_features

==============ignore.php -======================
`<?php

/* mod_ignore: This module allows a user to ignore messages posted by other users
author: Arthur Louie (arthur.louie@gmail.com)
version: 0.1
*/

if (!defined("PHORUM")) return;

// hook: read
function mod_ignore_read($messages)
{
global $PHORUM;

if (!$PHORUM['DATA']['LOGGEDIN']) return $messages;

$message_id = $PHORUM["args"][1];

// ------------------------------------------------------------
// Handle ignore / unignore requests
// ------------------------------------------------------------

// ignoreuser request
if (!empty($PHORUM["args"]['ignoreuser'])) {

    $target = $PHORUM["args"]['ignoreuser'];

    if (!is_array($PHORUM["user"]["mod_ignore"]) ||
        !in_array($target, $PHORUM["user"]["mod_ignore"]))
    {
        $userdata = array(
            'user_id'    => $PHORUM["user"]["user_id"],
            'mod_ignore' => $PHORUM["user"]["mod_ignore"]
        );

        $userdata["mod_ignore"][] = $target;

        phorum_api_user_save($userdata);

        phorum_redirect_by_url(
            phorum_get_url(PHORUM_READ_URL, $message_id)
        );
    }
}

// unignoreuser request
elseif (!empty($PHORUM["args"]['unignoreuser'])) {

    $target = $PHORUM["args"]['unignoreuser'];

    if (is_array($PHORUM["user"]["mod_ignore"]) &&
        in_array($target, $PHORUM["user"]["mod_ignore"]))
    {
        $userdata = array(
            'user_id'    => $PHORUM["user"]["user_id"],
            'mod_ignore' => $PHORUM["user"]["mod_ignore"]
        );

        foreach ($userdata["mod_ignore"] as $k => $v) {
            if ($v == $target) unset($userdata["mod_ignore"][$k]);
        }

        phorum_api_user_save($userdata);

        phorum_redirect_by_url(
            phorum_get_url(PHORUM_READ_URL, $message_id)
        );
    }
}

// ------------------------------------------------------------
// Javascript for toggling hidden messages
// ------------------------------------------------------------
$PHORUM['DATA']['MOD_IGNORE_JAVASCRIPT'] = <<<EOT

<script type="text/javascript"> function togglemsg(id) { var el = document.getElementById(id); if (!el) return; if (el.style.display === 'none') { el.style.display = 'block'; el.style.visibility = 'visible'; } else { el.style.display = 'none'; el.style.visibility = 'hidden'; } } </script>

EOT;

// ------------------------------------------------------------
// Mark ignored messages
// ------------------------------------------------------------
$ignore_list = is_array($PHORUM["user"]["mod_ignore"])
    ? $PHORUM["user"]["mod_ignore"]
    : array();

foreach ($messages as $key => $msg)
{
    $poster_id = $msg['user_id'];

    if (in_array($poster_id, $ignore_list)) {
        // Message is ignored
        $messages[$key]["mod_ignore"]      = 1;
        $messages[$key]["mod_ignore_text"] = $PHORUM["DATA"]["LANG"]["mod_ignore"]["show_msgs"];
        $messages[$key]["mod_ignore_url"]  =
            phorum_get_url(PHORUM_READ_URL, $message_id, "unignoreuser=$poster_id");
    } else {
        // Message is visible
        $messages[$key]["mod_ignore"]      = 0;
        $messages[$key]["mod_ignore_text"] = $PHORUM["DATA"]["LANG"]["mod_ignore"]["hide_msgs"];
        $messages[$key]["mod_ignore_url"]  =
            phorum_get_url(PHORUM_READ_URL, $message_id, "ignoreuser=$poster_id");
    }
}

return $messages;

}

// hook: format
function mod_ignore_format($messages)
{
global $PHORUM;

if (!$PHORUM['DATA']['LOGGEDIN']) return $messages;

foreach ($messages as $key => $msg)
{
    if (!empty($msg["mod_ignore"])) {

        $hide_start =
            "<font size=\"-2\"><a href=\"javascript: togglemsg('ig$key');\">" .
            $PHORUM["DATA"]["LANG"]["mod_ignore"]["click_to_toggle"] .
            "</a></font><br>" .
            "<span id=\"ig$key\" style=\"visibility:hidden; display:none;\">";

        $hide_end = "</span>";

        $messages[$key]['body'] = $hide_start . $messages[$key]['body'] . $hide_end;
    }
}

return $messages;

}

?>`

[tkolakow]

Another module with an issue is the Banner Manager version 1.0.4 - https://www.phorum.org/support/read.php?62,123956

When adding a banner block via the "Define banner blocks" tab, the buttons at the bottom of the tab do not load (Preview, Ok, Cancel). These are controlled via the "setting_banners_edit.php" file from what I can tell.

[tkolakow]

Another module with an issue is the BBCode Video version 1.0.10 - no link provided

After installing, the settings page does not load

[tkolakow]

Another module with issues is the Last Forum Post version 1.2.0 - no link provided

After installing, ensuring that changes existed in the required .tpl files, clicking the "Rebuild last post info for all forums" button in the module's settings, and then trying to post a message, I get a 500 error -

mod_fcgid: stderr: PHP Fatal error: Uncaught Error: Call to undefined function each() in /var/www/vhosts/xxxxxxx.com/httpdocs/phorum606/mods/last_forum_post/last_forum_post.php:30, referer: https://xxxxxxxx.com/phorum606/posting.php?3,reply,3

[tkolakow]

Topic Polls has been updated. It will require a new release of Phorum 6 too though.

It seems that the new zip file uploaded to the official Phroum thread for this plugin is empty. ;-)

[tkolakow]

Topic Polls has been updated. It will require a new release of Phorum 6 too though.

It seems that the mew zip file uploaded to the official Phroum thread for this plugin is empty. ;-)

User Avatars worked fine for me with 6.0.4. I am still working on finding the others in the Modules forum.

Interesting..... yep, it's working for me also. Must have been a mistake on my end. Sorry about that.

[tkolakow]

ok Brian, I think I've completed my initial pass through all of the installed modules that we are currently using in version 5. Let me know if there's anything else needed from me and I'll do my best to help. We appreciate your efforts!

[brianlmoon]

Have you updated to Phorum 6.0.6 yet? I think that will fix several of the modules. They were either trying to do thing with custom fields which had a PHP 8 issue or they were checking the constant phorum_page which was not defined in the admin and throws an error in PHP 8. The TOS module works fine for me against 6.0.6 for example. But looking at the code it would have failed before 6.0.6.