Skip to content

2DOF ODE's do not use solver group flag #1198

@jkirk5

Description

@jkirk5

Description

Various ODE's in the 2DOF mission have solver groups for things such as thrust/drag balance, but they do not use the "solver group" flag to determine if a subsystem should belong in the group. This means that external subsystems that ask to be added to the group might not be.

Example

Depending on how the existing solvers are set up in the ODEs we may want to either have a second solver group for those subsystems, or we add them to the existing required solver groups.

It is ok for the 2DOF ODEs to force certain subsystem types (such as PropulsionBuilders) to be added to a specific solver group, even if that subsystem ends up being a user-provided subsystem. In general, it is better to add a system to the solver group when that wasn't strictly necessary then not adding a system to the solver group that needed to be there.

Error Message

No response

Aviary Version

1.0.1-dev

Environment Information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No fields configured for Bug.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions