[BUG] Accuracy overlay shows wrong values for Nailgun

[The-Gig]

It's possible to bind "+acc" command to a key in order to get an "Accuracy overlay" shown while holding that key.
Example /bind l "+acc" will make the table show when you will be holding the "l" key.

But the percentages shown for Nailgun are clearly wrong. You may fire a single shot at close range and then see a 600% accuracy for that weapon, which makes no sense. I mean, if one or more nails of a single shot hit, you should consider it 1 hit/1 shot; if no nails hit, you should consider 0 hit/1 shot.

Maybe the problem could be somehow related to the fact that a single Nailgun shot actually fires 15 nails, which reach the target at different times.

Considerations:

• Wondering whether "Accuracy" medal (which is single player deathmatch only, which is earned if you land more than 50% of shots) calculations are affected, too. Harder to test, I fear... By the way, considering Accuracy Overlay does not consider Gauntlet and Proximity Mines, I wonder whether Accuracy Medal considers them or not.
• Shotgun seems to do not have the same issue. Considering that's an hitscan (instant hit) weapon, I guess the code is quite different.
• While doing the testing, be aware that to update the stats shown there, you have to release and push the button again, as the table is not updated automatically. IDK if that's on purpose to be able to see the stats of a "static" moment instead of ever-changing values or to prevent excessive computational work... or just an overlook. Thinking about it, if the table would have been updated automatically, people would have been able to enable/disable the overlay by typing /+acc and /-acc in console, which may have been nice, although not really definitive anyway (just a simple vid_restart would have disabled it again).

[NeonKnightOA]

Before tackling this issue, I need to finish developer mode. That way we can properly take a look at what's actually happening.

[NeonKnightOA]

Does the bug still appear in the newer versions?

[The-Gig]

Yes, I just shot a close range nailgun in OAX B53 and got 300% accuracy.

[NeonKnightOA]

Does it happen with the other weapons as well or solely with the Nailgun? I haven't checked yet the game module (only cgame).

[The-Gig]

IIRC, it's just the nailgun.
(Things mentioned in "considerations" part might refer to other weapons, though).

[NeonKnightOA]

I need to know in which situation the bug is triggered and if it happens with these releases:

• Last nightly
• b53
• Last 2023 nightly
• b52
• First nightly
• 0.8.8

[The-Gig]

About "the situations the bug is triggered", to put it very shortly, just hit with nailgun point-blank and then check the accuracy overlay, it will show a value above 100%, which shouldn't be possible. Please read the opening post for more information.

Tested in 0.8.8, oax B53 and nightly build 2024-03-27_1c0587e. It can be safely assumed it's there also in all intermediate releases.

[NeonKnightOA]

I've added D/L links to my last post.

[NeonKnightOA]

So it's a situation that takes place prior to 0.8.8 then. Sounds like a factory bug.

Still it needs to be fixed.