Skip to content

Commit 94bb777

Browse files
committed
fix(lint): add invoker trigger element reference
Signed-off-by: Cory Rylan <crylan@nvidia.com>
1 parent 8edcd76 commit 94bb777

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

‎projects/lint/src/eslint/rules/no-invalid-invoker-triggers.test.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import noInvalidInvokerTriggers from './no-invalid-invoker-triggers.js';
1010
const rule = noInvalidInvokerTriggers as unknown as JSRuleDefinition;
1111

1212
const validElements =
13-
'nve-button, nve-icon-button, nve-menu-item, nve-sort-button, nve-tabs-item, nve-tag, nve-steps-item, nve-copy-button, nve-media-fullscreen-button, nve-media-mute-button, nve-media-pause-button, nve-media-playback-rate-select, nve-media-seek-button, nve-media-time-range, nve-media-volume-range';
13+
'nve-button, nve-icon-button, nve-menu-item, nve-sort-button, nve-tabs-item, nve-tag, nve-steps-item, nve-copy-button, nve-media-fullscreen-button, nve-media-mute-button, nve-media-pause-button, nve-media-pip-button, nve-media-playback-rate-select, nve-media-seek-button, nve-media-time-range, nve-media-volume-range';
1414

1515
describe('noInvalidInvokerTriggers', () => {
1616
let tester: RuleTester;
@@ -64,6 +64,7 @@ describe('noInvalidInvokerTriggers', () => {
6464
'<nve-icon-button commandfor="my-panel"></nve-icon-button>',
6565
'<nve-tag commandfor="my-panel">Tag</nve-tag>',
6666
'<nve-media-pause-button commandfor="my-player"></nve-media-pause-button>',
67+
'<nve-media-pip-button commandfor="my-player"></nve-media-pip-button>',
6768
'<nve-media-playback-rate-select commandfor="my-player"></nve-media-playback-rate-select>',
6869
'<nve-media-mute-button commandfor="my-player"></nve-media-mute-button>',
6970
'<nve-media-seek-button commandfor="my-player"></nve-media-seek-button>',

‎projects/lint/src/eslint/rules/no-invalid-invoker-triggers.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ const BUTTON_TYPE_ELEMENTS = [
2828
'nve-media-fullscreen-button',
2929
'nve-media-mute-button',
3030
'nve-media-pause-button',
31+
'nve-media-pip-button',
3132
'nve-media-playback-rate-select',
3233
'nve-media-seek-button',
3334
'nve-media-time-range',

0 commit comments

Comments
 (0)