Problem
hooks/monitor-open-prs.py (docstring line 2, and the gh search prs --author @me call around line 91) polls only PRs the authenticated user authored.
#2913 records the PR-scope rule as four arms: a PR is in scope when the invoking user opened it, is assigned to it, named it in the request, or a repository workflow (github-actions[bot]) opened it. The monitor covers the first arm only, so a PR the user is assigned to, or a workflow-opened PR the user is driving (e.g. a bump-submodule.yml PR), is never reconciled by the hook.
Found by the fourth adversarial self-review round on #2913 (the automated reviewer was quota-skipped on that PR's later heads). Pre-existing, so deferred out of that PR rather than widening it.
Proposal
Widen the query to the same population skills/ardia/SKILL.md step 1 now filters on: --author @me OR --assignee @me OR --author app/github-actions (the gh spelling of the workflow bot; memories/reviewing-prs.md lists the forms). Union the three searches, or switch to gh pr list --json number,author,assignees per repo and apply the memory's test in Python. Add a case to the hook's tests for each arm.
Refs #2913.
Problem
hooks/monitor-open-prs.py(docstring line 2, and thegh search prs --author @mecall around line 91) polls only PRs the authenticated user authored.#2913 records the PR-scope rule as four arms: a PR is in scope when the invoking user opened it, is assigned to it, named it in the request, or a repository workflow (
github-actions[bot]) opened it. The monitor covers the first arm only, so a PR the user is assigned to, or a workflow-opened PR the user is driving (e.g. abump-submodule.ymlPR), is never reconciled by the hook.Found by the fourth adversarial self-review round on #2913 (the automated reviewer was quota-skipped on that PR's later heads). Pre-existing, so deferred out of that PR rather than widening it.
Proposal
Widen the query to the same population
skills/ardia/SKILL.mdstep 1 now filters on:--author @meOR--assignee @meOR--author app/github-actions(theghspelling of the workflow bot;memories/reviewing-prs.mdlists the forms). Union the three searches, or switch togh pr list --json number,author,assigneesper repo and apply the memory's test in Python. Add a case to the hook's tests for each arm.Refs #2913.