Refine multiselection#248
Merged
Merged
Conversation
- replace @input() decorators with input() - adjust icons in selection-tab - add functionality to add a range of elements to selection by pressing shift-button
- use page coordinates and auto-scroll to keep box stable during scrolling - remove some unnecessary imports
- border was too dark (change box-shadow when selected) - set searchbar-width according to width of cards (slightly)
- Replace @ViewChild with viewChild/viewChild.required signals - Replace @Output/EventEmitter with output() - Keep @ViewChildren with read option (not yet supported in signal API)
- move gridItem ref to div element to enable viewChildren signal migration - remove unused imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last changes of #177 :